From: Gen Zhang <blackgod016574@gmail.com>
To: paul@paul-moore.com, tony.luck@intel.com, sds@tycho.nsa.gov,
eparis@parisplace.org
Cc: selinux@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org
Subject: [PATCH] hooks: fix a missing-check bug in selinux_sb_eat_lsm_opts()
Date: Thu, 30 May 2019 11:53:10 +0800 [thread overview]
Message-ID: <20190530035310.GA9127@zhanggen-UX430UQ> (raw)
In selinux_sb_eat_lsm_opts(), 'arg' is allocated by kmemdup_nul(). It
returns NULL when fails. So 'arg' should be checked.
Signed-off-by: Gen Zhang <blackgod016574@gmail.com>
---
diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index 3ec702c..5a9e959 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -2635,6 +2635,8 @@ static int selinux_sb_eat_lsm_opts(char *options, void **mnt_opts)
*q++ = c;
}
arg = kmemdup_nul(arg, q - arg, GFP_KERNEL);
+ if (!arg)
+ return 0;
}
rc = selinux_add_opt(token, arg, mnt_opts);
if (unlikely(rc)) {
next reply other threads:[~2019-05-30 3:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 3:53 Gen Zhang [this message]
2019-05-30 4:39 ` William Roberts
2019-05-30 7:38 ` Gen Zhang
2019-05-30 8:28 ` Ondrej Mosnacek
2019-05-30 8:51 ` [PATCH v2] " Gen Zhang
2019-05-30 11:52 ` Ondrej Mosnacek
2019-05-30 15:16 ` William Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190530035310.GA9127@zhanggen-UX430UQ \
--to=blackgod016574@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=eparis@parisplace.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®