From: Gen Zhang <blackgod016574@gmail.com>
To: inaky.perez-gonzalez@intel.com
Cc: linux-wimax@intel.com, linux-kernel@vger.kernel.org
Subject: [PATCH] wimax: debug: fix a missing-check bug in d_parse_params()
Date: Thu, 30 May 2019 17:39:37 +0800 [thread overview]
Message-ID: <20190530093937.GA4457@zhanggen-UX430UQ> (raw)
In d_parse_params(), 'params_orig' is allocated by kstrdup(). It returns
NULL when fails. So 'params_orig' should be checked.
Signed-off-by: Gen Zhang <blackgod016574@gmail.com>
---
diff --git a/include/linux/wimax/debug.h b/include/linux/wimax/debug.h
index aaf24ba..bacd6cb 100644
--- a/include/linux/wimax/debug.h
+++ b/include/linux/wimax/debug.h
@@ -496,6 +496,11 @@ void d_parse_params(struct d_level *d_level, size_t d_level_size,
if (_params == NULL)
return;
params_orig = kstrdup(_params, GFP_KERNEL);
+ if (!params_orig) {
+ printk(KERN_ERR "%s: can't duplicate string '%s'\n",
+ tag, _params);
+ return;
+ }
params = params_orig;
while (1) {
token = strsep(¶ms, " ");
next reply other threads:[~2019-05-30 9:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 9:39 Gen Zhang [this message]
2019-06-05 6:33 ` Jiri Slaby
2019-06-05 16:11 ` Gen Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190530093937.GA4457@zhanggen-UX430UQ \
--to=blackgod016574@gmail.com \
--cc=inaky.perez-gonzalez@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wimax@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®