From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECE52C04AB5 for ; Mon, 3 Jun 2019 13:05:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B4E0727FCE for ; Mon, 3 Jun 2019 13:05:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559567117; bh=hvxRq+vA9NJlN13fkQsg4UkvRkk5tlRIY54i7UP0W08=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=fAi0f8pbrrg5dEOWF9L1wg80sBgZvNnr2nLB58piuZX1bBdLsCkD1TBg0eQZL3tF1 wsp1Jm2MU0MqnPXfaVAXa2Invpam2DxDQU6yoQM6Ud+RAwtc5jMgcac/RcUzsLqVA0 +qfvh9cU1tcIcAA7hyKMRo/mxrHLm9LHyZTegYXE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728230AbfFCNFQ (ORCPT ); Mon, 3 Jun 2019 09:05:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:38770 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726336AbfFCNFQ (ORCPT ); Mon, 3 Jun 2019 09:05:16 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 36E7C27F5E; Mon, 3 Jun 2019 13:05:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559567115; bh=hvxRq+vA9NJlN13fkQsg4UkvRkk5tlRIY54i7UP0W08=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=F7REBrsAD78ynBHQ/dAPvj7q58oyGl8zRMPnwBFkThTZX7TVNNJRHOv5JVjgFdzaZ gHUEot/83QUyDDCxVeDHP3T98ENuNCQx5dz9Yxl9ecz6Ffrwz79ko1OkNq3OiZ3azZ hdB4ltHX4jF4s6BD68IjmUZ2DrKZggSDFU0ywiqU= Date: Mon, 3 Jun 2019 15:05:13 +0200 From: Greg KH To: Christian =?iso-8859-1?Q?M=FCller?= Cc: johnfwhitmore@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-kernel@i4.cs.fau.de, felix.trommer@hotmail.de Subject: Re: [PATCH 3/3] drivers/staging/rtl8192u: Fix of checkpatch-errors Message-ID: <20190603130513.GB30732@kroah.com> References: <20190603122104.2564-1-muellerch-privat@web.de> <20190603122104.2564-4-muellerch-privat@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190603122104.2564-4-muellerch-privat@web.de> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 03, 2019 at 02:21:04PM +0200, Christian Müller wrote: > Fix issues that lead to multiple checkpatch warnings and errors, most of > them regarding formatting of code and comments. > Comments that contain only commented out code are removed as well. > > Signed-off-by: Felix Trommer > Signed-off-by: Christian Müller - Your patch did many different things all at once, making it difficult to review. All Linux kernel patches need to only do one thing at a time. If you need to do multiple things (such as clean up all coding style issues in a file/driver), do it in a sequence of patches, each one doing only one thing. This will make it easier to review the patches to ensure that they are correct, and to help alleviate any merge issues that larger patches can cause. - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot