From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B977C28CC6 for ; Mon, 3 Jun 2019 13:59:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6292526E82 for ; Mon, 3 Jun 2019 13:59:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XorbrS9w" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728655AbfFCN7v (ORCPT ); Mon, 3 Jun 2019 09:59:51 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:46719 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727645AbfFCN7u (ORCPT ); Mon, 3 Jun 2019 09:59:50 -0400 Received: by mail-lj1-f193.google.com with SMTP id m15so8006001ljg.13; Mon, 03 Jun 2019 06:59:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=vcIulk1/05i3H3O56SoVs73mT/TuSYKU/0fOegYFnxg=; b=XorbrS9wQiwZEHNOg7M/It2oguH2TnWDInhMG/FuFIm7vNvAHIPJbkftW2hAJkqtPt j6hRiv+mT4Ywy1NZEoj014JrkmfFJfdSCPjpT/knaO3KuyymgbUJSonYy5jkcz24zqcE zuIvxNP3rZKupgoEripEfh7qoi5bzMG4w6Iiz5cA7p/80YvZIDfUU8hHz2QZIqi+A/H5 P0RdxCSa1nYBFiM1RnViiOoediFY9tm8u7FFhvtAM0dty7DksSwVczire2TYKUzcgjpH XpqaCbWf2N/Lkh9SDKp7Q93+GOsApOQE4EbY4zoCT4GHTzSvyVORARr4Z/ZqyQDjVsTI XgVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vcIulk1/05i3H3O56SoVs73mT/TuSYKU/0fOegYFnxg=; b=EtAcRmWJFGOdwy/sEPU3mLOuuM2fLO/W40+x5589XQ4pPr99fNi6cnLVLbDWNsOo3J y2iPjmwM/fug2HhUyfr79Netg99CK2jmZKuNHS/d520ISMX4ZBReBt7AjDwDJMRBWQ9t HbpOlTKNe5atTk96QSuIyCdnnBcgvTt0nPXmxiRSsbNwfROoAgQ6kCZCXT0iJoGls1jJ dZTVYh9smlJRw+ukXzP2INCkxu+8wsqRdzn4JAnn523IbII/YTt5TtgIpTM1KfJluTSP JYZ0qyPo7taS6yzdGEQBmPB3PcEZaNQA478ujtjLkzKfhUF8FwZR/EYuNDfFsw9RbFZ5 9vkw== X-Gm-Message-State: APjAAAUCbgyBjZN+3duyVCdVmOLDEQYqoaUl8KOWDgT8FS0etiH9ZMqz IqsQigMpv6gU4XK52vog2Oc= X-Google-Smtp-Source: APXvYqyFVBQYnGPoKwtTGlv44NljHekWGJjapzSzxqZN6bY43Dul5qCS1bh6iX6UugirvFhrzxp7Dw== X-Received: by 2002:a2e:301a:: with SMTP id w26mr4059172ljw.76.1559570388393; Mon, 03 Jun 2019 06:59:48 -0700 (PDT) Received: from pc636 ([37.139.158.167]) by smtp.gmail.com with ESMTPSA id c15sm272940lja.79.2019.06.03.06.59.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Jun 2019 06:59:47 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Mon, 3 Jun 2019 15:59:39 +0200 To: Krzysztof Kozlowski , Andrew Morton Cc: Andrew Morton , "Uladzislau Rezki (Sony)" , Michal Hocko , linux-mm@kvack.org, Marek Szyprowski , "linux-samsung-soc@vger.kernel.org" , linux-kernel@vger.kernel.org, Stephen Rothwell , Hillf Danton , Thomas Gleixner , Tejun Heo , Andrei Vagin Subject: Re: [BUG BISECT] bug mm/vmalloc.c:470 (mm/vmalloc.c: get rid of one single unlink_va() when merge) Message-ID: <20190603135939.e2mb7vkxp64qairr@pc636> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Krzysztof. On Mon, Jun 03, 2019 at 11:07:46AM +0200, Krzysztof Kozlowski wrote: > Hi, > > On recent next I see bugs during boot (after bringing up user-space or > during reboot): > kernel BUG at ../mm/vmalloc.c:470! > On all my boards. On QEMU I see something similar, although the > message is "Internal error: Oops - undefined instruction: 0 [#1] ARM", > > The calltrace is: > [ 34.565126] [] (__free_vmap_area) from [] > (__purge_vmap_area_lazy+0xd0/0x170) > [ 34.573963] [] (__purge_vmap_area_lazy) from [] > (_vm_unmap_aliases+0x1fc/0x244) > [ 34.582974] [] (_vm_unmap_aliases) from [] > (__vunmap+0x170/0x200) > [ 34.590770] [] (__vunmap) from [] > (do_free_init+0x40/0x5c) > [ 34.597955] [] (do_free_init) from [] > (process_one_work+0x228/0x810) > [ 34.606018] [] (process_one_work) from [] > (worker_thread+0x30/0x570) > [ 34.614077] [] (worker_thread) from [] > (kthread+0x134/0x164) > [ 34.621438] [] (kthread) from [] > (ret_from_fork+0x14/0x20) > > Full log here: > https://krzk.eu/#/builders/1/builds/3356/steps/14/logs/serial0 > https://krzk.eu/#/builders/22/builds/1118/steps/35/logs/serial0 > > Bisect pointed to: > 728e0fbf263e3ed359c10cb13623390564102881 is the first bad commit > commit 728e0fbf263e3ed359c10cb13623390564102881 > Author: Uladzislau Rezki (Sony) > Date: Sat Jun 1 12:20:19 2019 +1000 > mm/vmalloc.c: get rid of one single unlink_va() when merge > I have checked the linux-next. I can confirm it happens because of: mm/vmalloc.c: get rid of one single unlink_va() when merge The problem is that, it has been applied wrongly into linux-next tree for some reason, i do not why. Probably due to the fact that i based my work on 5.1/2-rcX, whereas linux-next is a bit ahead of it. If so, sorry for that. See below the clean patch for remotes/linux-next/master: diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 650c89f38c1e..0ed95b864e31 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -719,9 +719,6 @@ merge_or_add_vmap_area(struct vmap_area *va, /* Check and update the tree if needed. */ augment_tree_propagate_from(sibling); - /* Remove this VA, it has been merged. */ - unlink_va(va, root); - /* Free vmap_area object. */ kmem_cache_free(vmap_area_cachep, va); @@ -746,12 +743,11 @@ merge_or_add_vmap_area(struct vmap_area *va, /* Check and update the tree if needed. */ augment_tree_propagate_from(sibling); - /* Remove this VA, it has been merged. */ - unlink_va(va, root); + if (merged) + unlink_va(va, root); /* Free vmap_area object. */ kmem_cache_free(vmap_area_cachep, va); - return; } } -- 2.11.0 Andrew, i am not sure how to proceed with that. Should i send an updated series based on linux-next tip or you can fix directly that patch? Thank you! -- Vlad Rezki