From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C710C282CE for ; Mon, 3 Jun 2019 21:47:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EFFF224220 for ; Mon, 3 Jun 2019 21:47:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559598452; bh=dDw/l+09r2MaBLjcFFfJjSPZLvE2heCBtLMWGhQ6pBg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=nm3jVjiRINmxPGgCvk+KxdiqAYVJ4QJBD9ahjOkN1191/zE4sgfhIeyrPxbB3aAk/ w/CPdac5u9lv8dezDxZAQbWXVPYkQ+ZsTWLxQKNBC4K9DDITB4FfsXjG/MMjm3wU/T hU1fpT8xlijejdh4fw+YIlD+Z+NXGaeHf5NyZmpQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726617AbfFCVrb (ORCPT ); Mon, 3 Jun 2019 17:47:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:37636 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726595AbfFCVr3 (ORCPT ); Mon, 3 Jun 2019 17:47:29 -0400 Received: from akpm3.svl.corp.google.com (unknown [104.133.8.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 16FFB23CB8; Mon, 3 Jun 2019 21:47:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559598449; bh=dDw/l+09r2MaBLjcFFfJjSPZLvE2heCBtLMWGhQ6pBg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=2cBL6VGl6XPWx4El6h15JzACuh5Z0gGbMRGYppoMPJRfkSGgQhgWdgORMBN9uih7i 9F+FK8cz+WhuxjRCYmkQ0JhZXMg6JqAzleSBlLqw3c1DAIKtJhW6bGZuFpNfX7x6LH a935NDfathGNEhNKsfhBdRJm7z4wEb2LJ9FlJvU4= Date: Mon, 3 Jun 2019 14:47:28 -0700 From: Andrew Morton To: Maninder Singh Cc: herbert@gondor.apana.org.au, davem@davemloft.net, keescook@chromium.org, gustavo@embeddedor.com, joe@perches.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, a.sahrawat@samsung.com, pankaj.m@samsung.com, v.narang@samsung.com Subject: Re: [PATCH 3/4] zstd: move params structure to global variable to reduce stack usage Message-Id: <20190603144728.1f89a4264170aa612365fc2a@linux-foundation.org> In-Reply-To: <1559552526-4317-4-git-send-email-maninder1.s@samsung.com> References: <1559552526-4317-1-git-send-email-maninder1.s@samsung.com> <1559552526-4317-4-git-send-email-maninder1.s@samsung.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 3 Jun 2019 14:32:05 +0530 Maninder Singh wrote: > > Subject: [PATCH 3/4] zstd: move params structure to global variable to reduce stack usage If this affected lib/zstd/ I'd be alarmed. But it's a client of lib/zstd that is choosing to have a single kernel-wide copy. I'll rewrite this patch title to "crypto/zstd.c: ...".