From: Hariprasad Kelam <hariprasad.kelam@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Carmeli Tamir <carmeli.tamir@gmail.com>,
Nishad Kamdar <nishadkamdar@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH] Staging: emxx_udc: fix warning "sum of probable bitmasks, consider |"
Date: Tue, 4 Jun 2019 00:24:12 +0530 [thread overview]
Message-ID: <20190603185412.GA11183@hari-Inspiron-1545> (raw)
Knowing the fact that operator '|' is faster than '+'.
Its better we replace + with | in this case.
Issue reported by coccicheck
drivers/staging/emxx_udc/emxx_udc.h:94:34-35: WARNING: sum of probable
bitmasks, consider |
Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
---
drivers/staging/emxx_udc/emxx_udc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.h b/drivers/staging/emxx_udc/emxx_udc.h
index b8c3dee..88d6bda 100644
--- a/drivers/staging/emxx_udc/emxx_udc.h
+++ b/drivers/staging/emxx_udc/emxx_udc.h
@@ -91,7 +91,7 @@ int vbus_irq;
#define BIT30 0x40000000
#define BIT31 0x80000000
-#define TEST_FORCE_ENABLE (BIT18 + BIT16)
+#define TEST_FORCE_ENABLE (BIT18 | BIT16)
#define INT_SEL BIT10
#define CONSTFS BIT09
--
2.7.4
next reply other threads:[~2019-06-03 18:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 18:54 Hariprasad Kelam [this message]
2019-06-03 19:04 ` Greg Kroah-Hartman
2019-06-05 6:34 ` Hariprasad Kelam
2019-06-06 10:51 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190603185412.GA11183@hari-Inspiron-1545 \
--to=hariprasad.kelam@gmail.com \
--cc=carmeli.tamir@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nishadkamdar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®