From: "Simon Sandström" <simon@nikanor.nu>
To: gregkh@linuxfoundation.org
Cc: simon@nikanor.nu, jeremy@azazel.net, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 3/7] staging: kpc2000: remove unnecessary oom message in core.c
Date: Tue, 4 Jun 2019 00:29:12 +0200 [thread overview]
Message-ID: <20190603222916.20698-4-simon@nikanor.nu> (raw)
In-Reply-To: <20190603222916.20698-1-simon@nikanor.nu>
Fixes checkpatch.pl warning "Possible unnecessary 'out of memory'
message".
Signed-off-by: Simon Sandström <simon@nikanor.nu>
---
drivers/staging/kpc2000/kpc2000/core.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/kpc2000/kpc2000/core.c b/drivers/staging/kpc2000/kpc2000/core.c
index dc6940e6c320..a70665a202c3 100644
--- a/drivers/staging/kpc2000/kpc2000/core.c
+++ b/drivers/staging/kpc2000/kpc2000/core.c
@@ -319,11 +319,8 @@ static int kp2000_pcie_probe(struct pci_dev *pdev,
* Step 1: Allocate a struct for the pcard
*/
pcard = kzalloc(sizeof(struct kp2000_device), GFP_KERNEL);
- if (!pcard) {
- dev_err(&pdev->dev,
- "probe: failed to allocate private card data\n");
+ if (!pcard)
return -ENOMEM;
- }
dev_dbg(&pdev->dev, "probe: allocated struct kp2000_device @ %p\n",
pcard);
--
2.20.1
next prev parent reply other threads:[~2019-06-03 22:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 22:29 [PATCH 0/7] staging: kpc2000: various minor checkpatch fixes Simon Sandström
2019-06-03 22:29 ` [PATCH 1/7] staging: kpc2000: simplify comparisons to NULL in core.c Simon Sandström
2019-06-03 22:29 ` [PATCH 2/7] staging: kpc2000: remove unnecessary parentheses " Simon Sandström
2019-06-03 22:29 ` Simon Sandström [this message]
2019-06-03 22:29 ` [PATCH 4/7] staging: kpc2000: use __func__ in debug messages " Simon Sandström
2019-06-06 12:55 ` Greg KH
2019-06-10 7:20 ` Simon Sandström
2019-06-10 7:49 ` Greg KH
2019-06-03 22:29 ` [PATCH 5/7] staging: kpc2000: remove unnecessary include " Simon Sandström
2019-06-03 22:29 ` [PATCH 6/7] staging: kpc2000: use sizeof(var) in kzalloc call Simon Sandström
2019-06-03 22:29 ` [PATCH 7/7] staging: kpc2000: fix incorrect code comment in core.c Simon Sandström
2019-06-06 11:34 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190603222916.20698-4-simon@nikanor.nu \
--to=simon@nikanor.nu \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jeremy@azazel.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®