From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E1A2C282CE for ; Tue, 4 Jun 2019 04:08:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 16A8824C71 for ; Tue, 4 Jun 2019 04:08:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726354AbfFDEIw (ORCPT ); Tue, 4 Jun 2019 00:08:52 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:17662 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725267AbfFDEIw (ORCPT ); Tue, 4 Jun 2019 00:08:52 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id C13FA121CC2D2C73DBD3; Tue, 4 Jun 2019 12:08:48 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.439.0; Tue, 4 Jun 2019 12:08:39 +0800 From: Kefeng Wang To: Greg Kroah-Hartman , "Rafael J. Wysocki" CC: , Kefeng Wang Subject: [PATCH] driver core: show the error number when driver_sysfs_add() fails Date: Tue, 4 Jun 2019 12:15:46 +0800 Message-ID: <20190604041546.54380-1-wangkefeng.wang@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If driver_sysfs_add() fails, kernel shows following message, really_probe: driver_sysfs_add(portman.0) failed ppdev: probe of portman.0 failed with error 0 It's better to show the error number like other probe_failed path. Signed-off-by: Kefeng Wang --- drivers/base/dd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/base/dd.c b/drivers/base/dd.c index 0df9b4461766..04ee4e196530 100644 --- a/drivers/base/dd.c +++ b/drivers/base/dd.c @@ -493,7 +493,8 @@ static int really_probe(struct device *dev, struct device_driver *drv) goto probe_failed; } - if (driver_sysfs_add(dev)) { + ret = driver_sysfs_add(dev); + if (ret) { printk(KERN_ERR "%s: driver_sysfs_add(%s) failed\n", __func__, dev_name(dev)); goto probe_failed; -- 2.20.1