From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECAC1C282CE for ; Tue, 4 Jun 2019 10:49:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C1E5624020 for ; Tue, 4 Jun 2019 10:49:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=brauner.io header.i=@brauner.io header.b="OG89WYXT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727356AbfFDKtp (ORCPT ); Tue, 4 Jun 2019 06:49:45 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:53518 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727314AbfFDKto (ORCPT ); Tue, 4 Jun 2019 06:49:44 -0400 Received: by mail-wm1-f67.google.com with SMTP id d17so6609069wmb.3 for ; Tue, 04 Jun 2019 03:49:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brauner.io; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=vViK9iDBq0w7sSxA4M0XBnW0Fmujup3yxcFIA5uIpT8=; b=OG89WYXTcHrbkkEkToBjQKNuSkXw/t8xOy/BkSMU3xc9KaBQYczgbGjv25yIoDTps5 lCpf5uaq5nTUGNZ8PcpvrjcFU6WzGDSwpS4jXWCCvdoCRQFKUG9jIA4sRZyb5vz3qY2T 9lT0yTFWNzhcPqRDNp0psJ2F71DXuhvP8YCPss0MKRhIZEsl2xy5DKi8MEZhKn+7o8gA vvmXJQi2dme9aZV7HgGJlrzfmuY+pDDjkH76aTY9tqUqTJYsh99c9R9YiQNK63wXg8i7 6+ji2m6nQI50pqSQ58KU3Crju0zAu5S78uu8JgVE8wQCCmDqrKNLEkXWKRPP1u0RrH1O aLkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vViK9iDBq0w7sSxA4M0XBnW0Fmujup3yxcFIA5uIpT8=; b=EoXw3YiMYmORfPDZZRImR7x6arUOQk+B/A90uI4yg7cL9kDpXbQk2/sa99gNJ7+4Ek 6F+1/efQOVBkZJIQi8Q91mJjgCX+sGp0NIuzmH/8Uw26PR32e2NvbW0jCDxZ86Jo3Tp6 wp+W9VGrffNcaTT0JjkSjOuYH/UtdFf3n3sowCn/X9VyojG+ymBrsGB74PWPWB64pi2d juxkjbYwLg+aCsIWBxgCmi2Ur0Rs+XeSJtZy/cn6tQi3FGvVTaZ+h8MWbOzejuO2LVvn x4fuJ1nLN/cpqUxbyrjPg8cLYL0Hy5cdZdYp2FqLMmAUAOc2bJtMksfgzFKgji+SZ1x0 bTVg== X-Gm-Message-State: APjAAAWCFSFbvQ2/XWuPW85er0nwqS56M0oQHXSsSIpgDYs5UWHdHSau /yQFslGDZmfcaVj0diPP8o1BnA== X-Google-Smtp-Source: APXvYqy0w2T8R3fUWh6dUOaQLjmFlN3Lf+wNQ+2da0sBml+vM01wMS4XK1ysNqktEP9sAxCQos1hkA== X-Received: by 2002:a7b:ca4c:: with SMTP id m12mr16736629wml.37.1559645381967; Tue, 04 Jun 2019 03:49:41 -0700 (PDT) Received: from brauner.io ([212.91.227.56]) by smtp.gmail.com with ESMTPSA id k2sm29193302wrg.41.2019.06.04.03.49.40 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 04 Jun 2019 03:49:41 -0700 (PDT) Date: Tue, 4 Jun 2019 12:49:40 +0200 From: Christian Brauner To: Arnd Bergmann Cc: Al Viro , Linux Kernel Mailing List , Linus Torvalds , Jann Horn , Kees Cook , Florian Weimer , Oleg Nesterov , David Howells , Pavel Emelyanov , Andrew Morton , Adrian Reber , Andrei Vagin , Linux API Subject: Re: [PATCH v2 1/2] fork: add clone3 Message-ID: <20190604104939.e7qhojiarfb2m3rh@brauner.io> References: <20190603144331.16760-1-christian@brauner.io> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 04, 2019 at 12:36:24PM +0200, Arnd Bergmann wrote: > On Mon, Jun 3, 2019 at 4:44 PM Christian Brauner wrote: > > > + > > +#ifdef __ARCH_WANT_SYS_CLONE > > +asmlinkage long sys_clone3(struct clone_args __user *uargs, size_t size); > > +#endif > > I would leave it outside of __ARCH_WANT_SYS_CLONE, as far > as I can tell the only reason for that #ifdef is so architectures that > have their own sys_clone implementation can opt out of the generic > one, but we don't want that for new syscalls. > > In fact, I'd prefer to drop the symbol entirely and have a different > symbol with the opposite meaning such as > __ARCH_NONSTANDARD_SYS_CLONE that only gets > selected by sparc, ia64 and m68k. That should be a separate > patch though, and I'm not asking you to do it, unless you > want to clean up a little more. I am totally up for this but I would prefer if we land clone3() in the 5.3 merge window and then for 5.3 rc{2,3} do the cleanups that David and you suggested. This leaves this patchset lean and easy to review. Christian