From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D551C282CE for ; Tue, 4 Jun 2019 12:51:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3BF7524987 for ; Tue, 4 Jun 2019 12:51:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727860AbfFDMvH (ORCPT ); Tue, 4 Jun 2019 08:51:07 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:42666 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727394AbfFDMvH (ORCPT ); Tue, 4 Jun 2019 08:51:07 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 88202A78; Tue, 4 Jun 2019 05:51:04 -0700 (PDT) Received: from arrakis.emea.arm.com (arrakis.cambridge.arm.com [10.1.196.78]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 77B853F690; Tue, 4 Jun 2019 05:51:03 -0700 (PDT) Date: Tue, 4 Jun 2019 13:51:00 +0100 From: Catalin Marinas To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Will Deacon , Mark Rutland Subject: Re: [PATCH] arm64/mm: Simplify protection flag creation for kernel huge mappings Message-ID: <20190604125100.GC6610@arrakis.emea.arm.com> References: <1558929495-19898-1-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1558929495-19898-1-git-send-email-anshuman.khandual@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 27, 2019 at 09:28:15AM +0530, Anshuman Khandual wrote: > Even though they have got the same value, PMD_TYPE_SECT and PUD_TYPE_SECT > get used for kernel huge mappings. But before that first the table bit gets > cleared using leaf level PTE_TABLE_BIT. Though functionally they are same, > we should use page table level specific macros to be consistent as per the > MMU specifications. Create page table level specific wrappers for kernel > huge mapping entries and just drop mk_sect_prot() which does not have any > other user. > > Signed-off-by: Anshuman Khandual > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Mark Rutland Queued for 5.3. Thanks. -- Catalin