mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
	Jiri Olsa <jolsa@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/22] perf intel-pt: Fix itrace defaults for perf script
Date: Tue, 4 Jun 2019 10:20:44 -0300	[thread overview]
Message-ID: <20190604132044.GA24504@kernel.org> (raw)
In-Reply-To: <7f73ed6e-7935-b325-14af-0b9e43144ed4@intel.com>

Em Tue, Jun 04, 2019 at 02:32:15PM +0300, Adrian Hunter escreveu:
> On 31/05/19 7:45 PM, Arnaldo Carvalho de Melo wrote:
> > Em Mon, May 20, 2019 at 11:45:16AM -0300, Arnaldo Carvalho de Melo escreveu:
> >> Em Mon, May 20, 2019 at 02:37:07PM +0300, Adrian Hunter escreveu:
> >>> Commit 4eb068157121 ("perf script: Make itrace script default to all
> >>> calls") does not work because 'use_browser' is being used to determine
> >>> whether to default to periodic sampling (i.e. better for perf report).
> >>> The result is that nothing but CBR events display for perf script
> >>> when no --itrace option is specified.

> >>> Fix by using 'default_no_sample' and 'inject' instead.

> >> Applied 1-3 for now, concentrating on fixes, will process 4-22 later.

> > Tested the ones that affect sqlite databases an the GUI, all look good,
> > added committer notes and text screenshots as committer notes, thanks!
 
> Thanks for applying!  Are patches 11-22 in your tree?

Yeah, delayed a bit push out as I was doing some automated tests, see
below what is there right now, if there is something missing, please let
me know, I also added commiter notes to most of them as I tested to see
if the comments matched the code and end GUI results.

- Arnaldo

ed1108bd8107 (HEAD -> perf/core, quaco/perf/core, acme/perf/core) perf augmented_raw_syscalls: Tell which args are filenames and how many bytes to copy
095b72ea8bc6 perf scripts python: exported-sql-viewer.py: Select find text when find bar is activated
08810ed07c90 perf scripts python: exported-sql-viewer.py: Add IPC information to Call Tree
96234e319dbe perf scripts python: exported-sql-viewer.py: Add IPC information to Call Graph Graph
18d0b3fa8f07 perf scripts python: exported-sql-viewer.py: Add CallGraphModelParams
a3f0fbba872e perf scripts python: exported-sql-viewer.py: Add IPC information to the Branch reports
44bd2140868f perf scripts python: export-to-postgresql.py: Export IPC information
ea76f3ba4a25 perf scripts python: export-to-sqlite.py: Export IPC information
75302e535b23 perf db-export: Export IPC information
a99d75fa022c perf db-export: Add brief documentation
0f9eea5e6974 perf thread-stack: Accumulate IPC information
1e80115f84a3 perf intel-pt: Document IPC usage
990917373744 perf intel-pt: Accumulate cycle count from TSC/TMA/MTC packets
17fa778da83e perf intel-pt: Re-factor TIP cases in intel_pt_walk_to_ip
dbb8dfd91a18 perf intel-pt: Record when decoding PSB+ packets
03386978a23b perf script: Add output of IPC ratio
f7c15a499e28 perf intel-pt: Add support for samples to contain IPC ratio
885ae6d43172 perf tools: Add IPC information to perf_sample
db3e60dd79a4 perf intel-pt: Accumulate cycle count from CYC packets
73a5a91c762d perf intel-pt: Factor out intel_pt_update_sample_time
3bbac0d75719 perf record: Allow mixing --user-regs with --call-graph=dwarf
7122f4bdb56d perf symbols: Remove unused variable 'err'
eea796aa2d6f perf data: Document directory format header: HEADER_DIR_FORMAT
cad909dc61fb perf data: Document clockid header: HEADER_CLOCKID
e1b3ce6a6898 perf data: Document memory topology header: HEADER_MEM_TOPOLOGY
8ab1ebfbb696 perf data: Add description of header HEADER_BPF_PROG_INFO and HEADER_BPF_BTF
b33fb3cf6f5e Merge tag 'perf-core-for-mingo-5.3-20190529' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core
14f1cfd4f7b4 (tag: perf-core-for-mingo-5.3-20190529) perf intel-pt: Rationalize intel_pt_sync_switch()'s use of next_tid
<SNIP>

  reply	other threads:[~2019-06-04 13:20 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-20 11:37 [PATCH 00/22] perf intel-pt: Add support for instructions-per-cycle (IPC) Adrian Hunter
2019-05-20 11:37 ` [PATCH 01/22] perf intel-pt: Fix itrace defaults for perf script Adrian Hunter
2019-05-20 13:58   ` Sasha Levin
2019-05-20 14:45   ` Arnaldo Carvalho de Melo
2019-05-31 16:45     ` Arnaldo Carvalho de Melo
2019-06-04 11:32       ` Adrian Hunter
2019-06-04 13:20         ` Arnaldo Carvalho de Melo [this message]
2019-05-30  7:53   ` [tip:perf/core] " tip-bot for Adrian Hunter
2019-05-20 11:37 ` [PATCH 02/22] perf auxtrace: " Adrian Hunter
2019-05-30  7:54   ` [tip:perf/core] " tip-bot for Adrian Hunter
2019-05-20 11:37 ` [PATCH 03/22] perf intel-pt: Fix itrace defaults for perf script intel-pt documentation Adrian Hunter
2019-05-30  7:54   ` [tip:perf/core] " tip-bot for Adrian Hunter
2019-05-20 11:37 ` [PATCH 04/22] perf intel-pt: Factor out intel_pt_update_sample_time Adrian Hunter
2019-06-17 18:59   ` [tip:perf/core] " tip-bot for Adrian Hunter
2019-05-20 11:37 ` [PATCH 05/22] perf intel-pt: Accumulate cycle count from CYC packets Adrian Hunter
2019-06-17 18:59   ` [tip:perf/core] " tip-bot for Adrian Hunter
2019-05-20 11:37 ` [PATCH 06/22] perf tools: Add IPC information to perf_sample Adrian Hunter
2019-06-17 19:00   ` [tip:perf/core] " tip-bot for Adrian Hunter
2019-05-20 11:37 ` [PATCH 07/22] perf intel-pt: Add support for samples to contain IPC ratio Adrian Hunter
2019-06-17 19:01   ` [tip:perf/core] " tip-bot for Adrian Hunter
2019-05-20 11:37 ` [PATCH 08/22] perf script: Add output of " Adrian Hunter
2019-06-17 19:01   ` [tip:perf/core] " tip-bot for Adrian Hunter
2019-05-20 11:37 ` [PATCH 09/22] perf intel-pt: Record when decoding PSB+ packets Adrian Hunter
2019-06-17 19:02   ` [tip:perf/core] " tip-bot for Adrian Hunter
2019-05-20 11:37 ` [PATCH 10/22] perf intel-pt: Re-factor TIP cases in intel_pt_walk_to_ip Adrian Hunter
2019-06-17 19:03   ` [tip:perf/core] " tip-bot for Adrian Hunter
2019-05-20 11:37 ` [PATCH 11/22] perf intel-pt: Accumulate cycle count from TSC/TMA/MTC packets Adrian Hunter
2019-06-17 19:04   ` [tip:perf/core] " tip-bot for Adrian Hunter
2019-05-20 11:37 ` [PATCH 12/22] perf intel-pt: Document IPC usage Adrian Hunter
2019-06-17 19:04   ` [tip:perf/core] " tip-bot for Adrian Hunter
2019-05-20 11:37 ` [PATCH 13/22] perf thread-stack: Accumulate IPC information Adrian Hunter
2019-06-17 19:05   ` [tip:perf/core] " tip-bot for Adrian Hunter
2019-05-20 11:37 ` [PATCH 14/22] perf db-export: Add brief documentation Adrian Hunter
2019-06-17 19:06   ` [tip:perf/core] " tip-bot for Adrian Hunter
2019-05-20 11:37 ` [PATCH 15/22] perf db-export: Export IPC information Adrian Hunter
2019-06-17 19:07   ` [tip:perf/core] " tip-bot for Adrian Hunter
2019-05-20 11:37 ` [PATCH 16/22] perf scripts python: export-to-sqlite.py: " Adrian Hunter
2019-06-17 19:07   ` [tip:perf/core] " tip-bot for Adrian Hunter
2019-05-20 11:37 ` [PATCH 17/22] perf scripts python: export-to-postgresql.py: " Adrian Hunter
2019-06-17 19:08   ` [tip:perf/core] " tip-bot for Adrian Hunter
2019-05-20 11:37 ` [PATCH 18/22] perf scripts python: exported-sql-viewer.py: Add IPC information to the Branch reports Adrian Hunter
2019-05-31 16:44   ` Arnaldo Carvalho de Melo
2019-06-03  5:50     ` Adrian Hunter
2019-06-17 19:09   ` [tip:perf/core] " tip-bot for Adrian Hunter
2019-05-20 11:37 ` [PATCH 19/22] perf scripts python: exported-sql-viewer.py: Add CallGraphModelParams Adrian Hunter
2019-06-17 19:09   ` [tip:perf/core] " tip-bot for Adrian Hunter
2019-05-20 11:37 ` [PATCH 20/22] perf scripts python: exported-sql-viewer.py: Add IPC information to Call Graph Graph Adrian Hunter
2019-06-17 19:10   ` [tip:perf/core] " tip-bot for Adrian Hunter
2019-05-20 11:37 ` [PATCH 21/22] perf scripts python: exported-sql-viewer.py: Add IPC information to Call Tree Adrian Hunter
2019-06-17 19:11   ` [tip:perf/core] " tip-bot for Adrian Hunter
2019-05-20 11:37 ` [PATCH 22/22] perf scripts python: exported-sql-viewer.py: Select find text when find bar is activated Adrian Hunter
2019-06-17 19:11   ` [tip:perf/core] " tip-bot for Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190604132044.GA24504@kernel.org \
    --to=arnaldo.melo@gmail.com \
    --cc=adrian.hunter@intel.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome