mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali.rohar@gmail.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: linux-kernel@vger.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: alps: Drop unlikely before IS_ERR(_OR_NULL)
Date: Wed, 5 Jun 2019 16:42:40 +0200	[thread overview]
Message-ID: <20190605144240.pfrvlgxsdpacpwxf@pali> (raw)
In-Reply-To: <20190605142428.84784-5-wangkefeng.wang@huawei.com>

On Wednesday 05 June 2019 22:24:28 Kefeng Wang wrote:
> IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag,
> so no need to do that again from its callers. Drop it.

Hi! I already reviewed this patch and rejected it, see:
https://patchwork.kernel.org/patch/10817475/

> Cc: "Pali Rohár" <pali.rohar@gmail.com>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: linux-input@vger.kernel.org
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
>  drivers/input/mouse/alps.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
> index 0a6f7ca883e7..791ef0f826c5 100644
> --- a/drivers/input/mouse/alps.c
> +++ b/drivers/input/mouse/alps.c
> @@ -1478,7 +1478,7 @@ static void alps_report_bare_ps2_packet(struct psmouse *psmouse,
>  		/* On V2 devices the DualPoint Stick reports bare packets */
>  		dev = priv->dev2;
>  		dev2 = psmouse->dev;
> -	} else if (unlikely(IS_ERR_OR_NULL(priv->dev3))) {
> +	} else if (IS_ERR_OR_NULL(priv->dev3)) {
>  		/* Register dev3 mouse if we received PS/2 packet first time */
>  		if (!IS_ERR(priv->dev3))
>  			psmouse_queue_work(psmouse, &priv->dev3_register_work,

-- 
Pali Rohár
pali.rohar@gmail.com

  reply	other threads:[~2019-06-05 14:42 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-05 14:24 [PATCH] fs: gfs2: Use IS_ERR_OR_NULL Kefeng Wang
2019-06-05 14:24 ` [PATCH] fs: cifs: Drop unlikely before IS_ERR(_OR_NULL) Kefeng Wang
2019-06-05 14:24 ` [PATCH net-next] net: " Kefeng Wang
2019-06-05 16:13   ` Jesse Brandeburg
2019-06-06  1:39     ` Kefeng Wang
2019-06-06 20:41       ` Enrico Weigelt, metux IT consult
2019-06-05 16:40   ` Neil Horman
2019-06-05 14:24 ` [PATCH] block: " Kefeng Wang
2019-06-05 14:22   ` Jens Axboe
2019-06-05 18:24   ` Enrico Weigelt, metux IT consult
2019-06-05 18:32     ` Joe Perches
2019-06-05 20:55       ` Enrico Weigelt, metux IT consult
2019-06-05 14:24 ` [PATCH] Input: alps: " Kefeng Wang
2019-06-05 14:42   ` Pali Rohár [this message]
2019-06-06  1:08     ` Kefeng Wang
2019-06-06  2:28       ` Joe Perches
2019-06-12  0:59         ` Dmitry Torokhov
2019-06-12  7:14           ` Pali Rohár
2019-06-12  8:35             ` Joe Perches
2019-06-11 16:23 ` [PATCH] fs: gfs2: Use IS_ERR_OR_NULL Andreas Gruenbacher
2019-06-12  1:07   ` Kefeng Wang
2019-06-12  1:17   ` [PATCH v2] " Kefeng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190605144240.pfrvlgxsdpacpwxf@pali \
    --to=pali.rohar@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wangkefeng.wang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®