From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97FD9C04AB5 for ; Thu, 6 Jun 2019 16:54:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6774820693 for ; Thu, 6 Jun 2019 16:54:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="INHNwSel" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728629AbfFFQyK (ORCPT ); Thu, 6 Jun 2019 12:54:10 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:44962 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727445AbfFFQyI (ORCPT ); Thu, 6 Jun 2019 12:54:08 -0400 Received: from pendragon.ideasonboard.com (unknown [IPv6:2a02:a03f:44f0:8500:ca05:8177:199c:fed4]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 349BF33B; Thu, 6 Jun 2019 18:54:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1559840046; bh=KU7bynOWQxEsZF9wVZ4WjYDe60zWXjq617V0v2YLhFM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=INHNwSelSFh4Y1SFZvTpHkfgSSQEgu3FcYWWbske5+W9Bsp2Mng4FCL31uLPgKlxm kT+x0kfvzqYOTCozj78CSliiv2JT1NpAlsJO1+mj9S8VIxNj9r+doIiLUs7mUh0l+r SOhLOwmFYYKzSS5lJe7hCIanuqB4IWc0sNJKFx4k= Date: Thu, 6 Jun 2019 19:53:52 +0300 From: Laurent Pinchart To: Jacopo Mondi Cc: kieran.bingham+renesas@ideasonboard.com, airlied@linux.ie, daniel@ffwll.ch, koji.matsuoka.xm@renesas.com, muroya@ksk.co.jp, VenkataRajesh.Kalakodima@in.bosch.com, Harsha.ManjulaMallikarjun@in.bosch.com, linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/20] dt-bindings: display, renesas,du: Update 'vsps' in example Message-ID: <20190606165352.GK12825@pendragon.ideasonboard.com> References: <20190606142220.1392-1-jacopo+renesas@jmondi.org> <20190606142220.1392-4-jacopo+renesas@jmondi.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190606142220.1392-4-jacopo+renesas@jmondi.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jacopo, Thank you for the patch. On Thu, Jun 06, 2019 at 04:22:03PM +0200, Jacopo Mondi wrote: > Update the 'vsps' property structure in the documentation example to > reflect what's actually implemented in the device tree sources. > > Signed-off-by: Jacopo Mondi > --- > Documentation/devicetree/bindings/display/renesas,du.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt b/Documentation/devicetree/bindings/display/renesas,du.txt > index 100114ef11d5..262047053d31 100644 > --- a/Documentation/devicetree/bindings/display/renesas,du.txt > +++ b/Documentation/devicetree/bindings/display/renesas,du.txt > @@ -92,7 +92,7 @@ Example: R8A7795 (R-Car H3) ES2.0 DU > <&cpg CPG_MOD 722>, > <&cpg CPG_MOD 721>; > clock-names = "du.0", "du.1", "du.2", "du.3"; > - vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>, <&vspd0 1>; > + vsps = <&vspd0 0 &vspd1 0 &vspd2 &vspd0 1>; The former is simpler to read than the latter in my opinion. Shouldn't we update the .dtsi files instead ? > cmms = <&cmm0 &cmm1 &cmm2 &cmm3>; > > ports { -- Regards, Laurent Pinchart