From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B25D5C04AB5 for ; Thu, 6 Jun 2019 17:07:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8A88220652 for ; Thu, 6 Jun 2019 17:07:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729708AbfFFRHR (ORCPT ); Thu, 6 Jun 2019 13:07:17 -0400 Received: from mga11.intel.com ([192.55.52.93]:26668 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725267AbfFFRHP (ORCPT ); Thu, 6 Jun 2019 13:07:15 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jun 2019 10:07:14 -0700 X-ExtLoop1: 1 Received: from buildpc-hp-z230.iind.intel.com (HELO buildpc-HP-Z230) ([10.223.89.34]) by fmsmga005.fm.intel.com with ESMTP; 06 Jun 2019 10:07:12 -0700 Date: Thu, 6 Jun 2019 22:37:50 +0530 From: Sanyog Kale To: Pierre-Louis Bossart Cc: Srinivas Kandagatla , vkoul@kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH v2] soundwire: stream: fix bad unlock balance Message-ID: <20190606170750.GA20839@buildpc-HP-Z230> References: <20190606112222.16502-1-srinivas.kandagatla@linaro.org> <9427a73a-e09a-4a9c-7690-271d2e2e1024@linux.intel.com> <43a381df-13d7-eaac-a1ae-704db5659cb9@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <43a381df-13d7-eaac-a1ae-704db5659cb9@linux.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 06, 2019 at 10:36:02AM -0500, Pierre-Louis Bossart wrote: > On 6/6/19 9:58 AM, Srinivas Kandagatla wrote: > > > > > > On 06/06/2019 15:28, Pierre-Louis Bossart wrote: > > > On 6/6/19 6:22 AM, Srinivas Kandagatla wrote: > > > > multi bank switching code takes lock on condition but releases without > > > > any check resulting in below warning. > > > > This patch fixes this. > > > > > > > > > Question to make sure we are talking about the same thing: > > > multi-link bank switching is a capability beyond the scope of the > > > SoundWire spec which requires hardware support to synchronize links > > > and as Sanyog hinted at in a previous email follow a different flow > > > for bank switches. > > > > > > You would not use the multi-link mode if you have different links > > > that can operate independently and have no synchronization > > > requirement. You would conversely use the multi-link mode if you > > > have two devices on the same type on different links and want audio > > > to be rendered at the same time. > > > > > > Can you clarify if indeed you were using the full-blown multi-link > > > mode with hardware synchronization or a regular single-link > > > operation? I am not asking for details of your test hardware, just > > > trying to reconstruct the program flow leading to this problem. > > > > > > > Am testing on a regular single link, which hits this path. > > > > > It could also be that your commit message was meant to say: > > > "the msg lock is taken for multi-link cases only but released > > > unconditionally, leading to an unlock balance warning for > > > single-link usages"? > > Yes. > > Thanks for the precision. the change is legit so assuming the commit message > is reworded to mention single link usage please feel free to take the > following tag. > > Acked-by: Pierre-Louis Bossart > Changes looks okay to me. Please update commit message as pierre suggested. Acked-by: Sanyog Kale > > Thanks! --