From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3657C2BCA1 for ; Fri, 7 Jun 2019 15:59:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B216720657 for ; Fri, 7 Jun 2019 15:59:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559923182; bh=xFULexyD9/K5lBAkx3sJQH53ybfnXEHI3FhWIIrHfFE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=biHYPSDY0xor8cKVRTYgzEnuQsFtBH7348d0INkdFh7iYTMGOL0drv5T2dHCWv63y IO1Odc5hJsU5ULupsanNp9dS7YJUu69t/p7L1GYMciL59+IrEAAujgbD1LaHdyuAHK gN54P3hE6DhedlbjAlmGShhQI+tdBmpYYJwB7hBM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730922AbfFGP7m (ORCPT ); Fri, 7 Jun 2019 11:59:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:51568 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730334AbfFGPlf (ORCPT ); Fri, 7 Jun 2019 11:41:35 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 41D46212F5; Fri, 7 Jun 2019 15:41:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559922094; bh=xFULexyD9/K5lBAkx3sJQH53ybfnXEHI3FhWIIrHfFE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qy1zL8lQ9L7y85llGR65LzRwVFv/wL94eHUnOQ4aC9g6Npb7rmmx38jOrf6z2Fx8N oJ4VGT6BNBCzsuxiouV8tANYJPfvsB7jrVGflVuVkZgnys1Dn3EfIXu4WvMZgfu2bT kIqW7buDaZX/IQPTB5gLoJm1qLEx74KhzkmsP6Bg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Oliver Neukum Subject: [PATCH 4.14 33/69] USB: rio500: fix memory leak in close after disconnect Date: Fri, 7 Jun 2019 17:39:14 +0200 Message-Id: <20190607153852.479966741@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190607153848.271562617@linuxfoundation.org> References: <20190607153848.271562617@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Oliver Neukum commit e0feb73428b69322dd5caae90b0207de369b5575 upstream. If a disconnected device is closed, rio_close() must free the buffers. Signed-off-by: Oliver Neukum Cc: stable Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/rio500.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) --- a/drivers/usb/misc/rio500.c +++ b/drivers/usb/misc/rio500.c @@ -99,9 +99,22 @@ static int close_rio(struct inode *inode { struct rio_usb_data *rio = &rio_instance; - rio->isopen = 0; + /* against disconnect() */ + mutex_lock(&rio500_mutex); + mutex_lock(&(rio->lock)); - dev_info(&rio->rio_dev->dev, "Rio closed.\n"); + rio->isopen = 0; + if (!rio->present) { + /* cleanup has been delayed */ + kfree(rio->ibuf); + kfree(rio->obuf); + rio->ibuf = NULL; + rio->obuf = NULL; + } else { + dev_info(&rio->rio_dev->dev, "Rio closed.\n"); + } + mutex_unlock(&(rio->lock)); + mutex_unlock(&rio500_mutex); return 0; }