From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 540DBC2BCA1 for ; Fri, 7 Jun 2019 17:57:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 30F90208C0 for ; Fri, 7 Jun 2019 17:57:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="l7QdhA2z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731199AbfFGR5v (ORCPT ); Fri, 7 Jun 2019 13:57:51 -0400 Received: from mail-qk1-f196.google.com ([209.85.222.196]:33040 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731052AbfFGR5v (ORCPT ); Fri, 7 Jun 2019 13:57:51 -0400 Received: by mail-qk1-f196.google.com with SMTP id r6so1816013qkc.0 for ; Fri, 07 Jun 2019 10:57:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Eah0lY26nouX6jt8kDz/kbBB5NIsRlLHybJGkfwuHUU=; b=l7QdhA2zAexmCT8J3YtIfSQtKsEDpkONNlD1mnbvFt2M2psEiAP3rmijzZwVZbYkhE 94YYbo8DJrrmOHxUUov4NMZWX7ihRN5zTPww1yXboP8LKe31YCkSrGa7dJm8sQPDOWjS s25u9b9HHpuXvhOWh8nQvzEvic3tjyTwGxULs9BhGlBaqM7xfRWC5gA+8byHdWXxJKES +nsvCWR2l9Otj92Dg7S990sQ9HSJwI8l9qs7Jl3CUUaPrYT4Uc6/PkExcaNdegGRog8i DVY/1b0VpH4mUaeEDBtQgT8hi4WePDUnmXEXakcCSAY8znaEucGjBeaYqN9mYpOjtsX7 bCfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Eah0lY26nouX6jt8kDz/kbBB5NIsRlLHybJGkfwuHUU=; b=c0BKZ5qwOPj5XSlNogS3UcA06e9iOUGLF4xGMk39DpKJqNdInvoh0/kyr9Av1eQc71 SkxX7KzcJD9ogjN+DTWxwu9P1HikPZh8ICG/oYybCaKg2BpFM+kL0O0yLpKNMbw8Pf7U j5QoUsE72Njp+zwvdyQ4U2m9cOWjIG2MaZSDGBh/utYXCBMhZttaOpwGRx7rS+tfSZ7a Pwr3thU43fPBSl45nI21uaoTUJJEXKMRi1cqigakdjiUi2F/uCfsHvjlZjlcaUUXde1f G2AAtrk5C2r0DbXQLyvq+F84IbuAXInskFWnHiDwIH9FAnEg62TRuvAlOf8vnTFnjfkF DGNw== X-Gm-Message-State: APjAAAWsK6zI+y9qijrDfKfX/JYs4yI3frmcCP3295c8iqRNMcxvPQPl 1/v8luYvHsiNrdEpEDn2nwnURuGbazTrlQ== X-Google-Smtp-Source: APXvYqx2b15MJDyfu3+q8xD+p4RRDwVFsKwGnnXkd4dB1jA2NyFGRpu375PpC/+/rJdRwAxb/Gmycg== X-Received: by 2002:a05:620a:533:: with SMTP id h19mr45133556qkh.325.1559930270129; Fri, 07 Jun 2019 10:57:50 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-55-100.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.55.100]) by smtp.gmail.com with ESMTPSA id c5sm1569499qkb.41.2019.06.07.10.57.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 07 Jun 2019 10:57:49 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1hZJ7d-0006Wl-Bm; Fri, 07 Jun 2019 14:57:49 -0300 Date: Fri, 7 Jun 2019 14:57:49 -0300 From: Jason Gunthorpe To: Colin King Cc: Lijun Ou , Wei Hu , Doug Ledford , linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2][next] RDMA/hns: fix comparison of unsigned long variable 'end' with less than zero Message-ID: <20190607175749.GB25014@ziepe.ca> References: <20190531092101.28772-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190531092101.28772-1-colin.king@canonical.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 31, 2019 at 10:21:00AM +0100, Colin King wrote: > From: Colin Ian King > > Currently the comparison of end with less than zero is always false > because end is an unsigned long. Also, replace checks of end with > non-zero with end > 0 as it is possible that the #defined decrement > may be changed in the future causing end to step over zero and go > negative. > > The initialization of end with 0 is also redundant as this value is > never read and is later set to HW_SYNC_TIMEOUT_MSECS, so fix this by > initializing it with this value to begin with. > > Addresses-Coverity: ("Unsigned compared against 0") > Fixes: 669cefb654cb ("RDMA/hns: Remove jiffies operation in disable interrupt context") > Signed-off-by: Colin Ian King > --- > drivers/infiniband/hw/hns/hns_roce_hem.c | 4 ++-- > drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 12 ++++++------ > 2 files changed, 8 insertions(+), 8 deletions(-) hns team: Can you please comment on this patch Jason