mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Fenghua Yu <fenghua.yu@intel.com>
To: James Morse <james.morse@arm.com>
Cc: linux-doc@vger.kernel.org, x86@kernel.org,
	Jonathan Corbet <corbet@lwn.net>,
	Reinette Chatre <reinette.chatre@intel.com>,
	Babu Moger <Babu.Moger@amd.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] Documentation: x86: Clarify MBA takes MB as referring to mba_sc
Date: Fri, 7 Jun 2019 14:28:10 -0700	[thread overview]
Message-ID: <20190607212809.GC143433@romley-ivt3.sc.intel.com> (raw)
In-Reply-To: <20190607151409.15476-4-james.morse@arm.com>

On Fri, Jun 07, 2019 at 04:14:08PM +0100, James Morse wrote:
> "If the MBA is specified in MB then user can enter the max b/w in MB"
> is a tautology. How can the user know if the schemata takes a percentage
> or a MB/s value?
> 
> This is referring to whether the software controller is interpreting
> the schemata's value. Make this clear.
> 
> Signed-off-by: James Morse <james.morse@arm.com>
> ---
>  Documentation/x86/resctrl_ui.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/x86/resctrl_ui.rst b/Documentation/x86/resctrl_ui.rst
> index 638cd987937d..866b66aa289b 100644
> --- a/Documentation/x86/resctrl_ui.rst
> +++ b/Documentation/x86/resctrl_ui.rst
> @@ -677,8 +677,8 @@ allocations can overlap or not. The allocations specifies the maximum
>  b/w that the group may be able to use and the system admin can configure
>  the b/w accordingly.
>  
> -If the MBA is specified in MB(megabytes) then user can enter the max b/w in MB
> -rather than the percentage values.
> +If resctrl is using the software controller (mba_sc) then user can enter the
> +max b/w in MB rather than the percentage values.
>  ::
>  
>    # echo "L3:0=3;1=c\nMB:0=1024;1=500" > /sys/fs/resctrl/p0/schemata
> -- 
> 2.20.1
> 

Acked-by: Fenghua Yu <fenghua.yu@intel.com>

Thanks.

-Fenghua

  reply	other threads:[~2019-06-07 21:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-07 15:14 [PATCH 0/4] Documentation: x86: resctrl_ui.txt fixes and clarification James Morse
2019-06-07 15:14 ` [PATCH 1/4] Documentation: x86: Contiguous cbm isn't all X86 James Morse
2019-06-07 21:24   ` Fenghua Yu
2019-06-07 15:14 ` [PATCH 2/4] Documentation: x86: Remove cdpl2 unspported statement and fix capitalisation James Morse
2019-06-07 21:26   ` Fenghua Yu
2019-06-07 15:14 ` [PATCH 3/4] Documentation: x86: Clarify MBA takes MB as referring to mba_sc James Morse
2019-06-07 21:28   ` Fenghua Yu [this message]
2019-06-07 15:14 ` [PATCH 4/4] Documentation: x86: fix some typos James Morse
2019-06-07 21:29   ` Fenghua Yu
2019-06-20 20:16 ` [PATCH 0/4] Documentation: x86: resctrl_ui.txt fixes and clarification Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190607212809.GC143433@romley-ivt3.sc.intel.com \
    --to=fenghua.yu@intel.com \
    --cc=Babu.Moger@amd.com \
    --cc=corbet@lwn.net \
    --cc=james.morse@arm.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=reinette.chatre@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome