From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40605C28CC5 for ; Sat, 8 Jun 2019 08:27:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 06AFB2146E for ; Sat, 8 Jun 2019 08:27:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ZJj422W2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726655AbfFHI1I (ORCPT ); Sat, 8 Jun 2019 04:27:08 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:39574 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725809AbfFHI1I (ORCPT ); Sat, 8 Jun 2019 04:27:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Yao0WJuh4CHaqpXA8+u+LeKxnCdbXD2rQwXbMvmoggw=; b=ZJj422W2IANAVOdOtXVPmUUiA yBVK2wmt+l3lq0/qlzojVDJwnWACjoNzxvjb8rz13EnMHPN7vt9BQ8Dmhz1BTPb0HteIfNGtIzE/c j710ixUna+o0nXOsNaEb9gsLYEnmhrVV8ahNzhlBe8hgXhhLTmJRDIm89f64zHe4aPETzb4UKItGp fSfKvaOEbffjoPGhOWhsUEmssdDIBkrfVGgSRvLvVFnbKvk0Cbkq8UaldlXtxiORNbu9VcdMMse4H kbWHMRASEhSJxq2Z8Jis5tMXZ5zYo8TrrlzsBe21ryEnoU3/J6yCArkTJoyQKuyz8HUQdgM/O09LO deiSICKxA==; Received: from hch by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1hZWgt-0003p5-8Z; Sat, 08 Jun 2019 08:27:07 +0000 Date: Sat, 8 Jun 2019 01:27:07 -0700 From: Christoph Hellwig To: Konstantin Khlebnikov Cc: Jens Axboe , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Monakhov Subject: Re: [PATCH] drivers/ata: cleanup creation of device sysfs attribute Message-ID: <20190608082707.GB9613@infradead.org> References: <155989288635.1536.11972713412534297217.stgit@buzz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <155989288635.1536.11972713412534297217.stgit@buzz> User-Agent: Mutt/1.11.4 (2019-03-13) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 07, 2019 at 10:34:46AM +0300, Konstantin Khlebnikov wrote: > This patch merges common ATA and AHCI specific attribute "sw_activity" > into one group with ->is_visible() method which hides attributes if > feature is not supported by hardware. > > This allows to add all attributes in one place without exporting > each piece for linking into another list in ahci module. > > Signed-off-by: Konstantin Khlebnikov Looks good, Reviewed-by: Christoph Hellwig