From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85F0CC28EBD for ; Sun, 9 Jun 2019 10:45:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 512BD2070B for ; Sun, 9 Jun 2019 10:45:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560077144; bh=iyzGTsUWW55gkRVtB+pFp4GxvLgteEbjoCT83KVsi/k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=MfsnuzY4bIVuZMvuLCVGve5dLw8QiU6wD3E2x4NNGugGSkdpoYW12WJPoMOKzHsV+ r+R5GT+dlStdehqx9AsD8ieyLuWENdZXXGG98jlRuJnVQzEBtyTG2XJyv2XfIDJKga xYuCSGk6VWS3tBoLtv77lhcUoe2DF8av9KJYXHrw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728108AbfFIKpn (ORCPT ); Sun, 9 Jun 2019 06:45:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:33662 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726710AbfFIKpn (ORCPT ); Sun, 9 Jun 2019 06:45:43 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 102AC2070B; Sun, 9 Jun 2019 10:45:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560077142; bh=iyzGTsUWW55gkRVtB+pFp4GxvLgteEbjoCT83KVsi/k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tdt4DzQYcbJzghLA/iZcCAO45d8Knt7ZjIzD6pvZvttVv4BHjg2REY0K9BG1GGqN5 GmDbdlaeOKN7BVoYkbNwivgKqva9TnqqsGH4fdlcQBEDU1oBehyo7fdkbqilxkf1Ob OegeBjjrhnV9cdTxbd4CEsKxzp641BsZDmAVoR14= Date: Sun, 9 Jun 2019 12:45:40 +0200 From: Greg Kroah-Hartman To: Hariprasad Kelam Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: hal: move common code to macro Message-ID: <20190609104540.GB7328@kroah.com> References: <20190609103232.GA9769@hari-Inspiron-1545> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190609103232.GA9769@hari-Inspiron-1545> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 09, 2019 at 04:02:32PM +0530, Hariprasad Kelam wrote: > > As part of halbtc8723b2ant_TdmaDurationAdjust function below > piece of code is used many times. > > halbtc8723b2ant_PsTdma(pBtCoexist, NORMAL_EXEC, true, val); > pCoexDm->psTdmaDuAdjType = val; > > This patch replaces this common code with MACRO > HAL_BTC8723B2ANT_DMA_DURATION_ADJUST Why is all of this indented? And line-wrapped at an odd column? Please use at lines around 72 characters long. > > Signed-off-by: Hariprasad Kelam > --- > drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c | 746 ++++++++++-------------- > 1 file changed, 293 insertions(+), 453 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c b/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c > index cb62fc0..56d842e 100644 > --- a/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c > +++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c > @@ -7,6 +7,13 @@ > > #include "Mp_Precomp.h" > > +/* defines */ > +#define HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(val) \ > +do { \ > + halbtc8723b2ant_PsTdma(pBtCoexist, NORMAL_EXEC, true, val); \ > + pCoexDm->psTdmaDuAdjType = val; \ > +} while (0) The goal is to move away from crazy macros, not add new ones :) But this does make the code a lot simpler, so it's ok. But please fix up the changelog text and resend. thanks, greg k-h