From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=y5Xy=UI=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,
	USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 4CB1AC28EBD
	for <linux-kernel@archiver.kernel.org>; Sun,  9 Jun 2019 10:53:52 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id F3385208E4
	for <linux-kernel@archiver.kernel.org>; Sun,  9 Jun 2019 10:53:51 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728175AbfFIKxv (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Sun, 9 Jun 2019 06:53:51 -0400
Received: from asavdk3.altibox.net ([109.247.116.14]:58357 "EHLO
        asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726710AbfFIKxu (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 9 Jun 2019 06:53:50 -0400
Received: from ravnborg.org (unknown [158.248.194.18])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by asavdk3.altibox.net (Postfix) with ESMTPS id 60FDF2002C;
        Sun,  9 Jun 2019 12:53:39 +0200 (CEST)
Date:   Sun, 9 Jun 2019 12:53:38 +0200
From:   Sam Ravnborg <sam@ravnborg.org>
To:     Jitao Shi <jitao.shi@mediatek.com>
Cc:     Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        linux-pwm@vger.kernel.org, David Airlie <airlied@linux.ie>,
        Matthias Brugger <matthias.bgg@gmail.com>, stonea168@163.com,
        dri-devel@lists.freedesktop.org,
        Andy Yan <andy.yan@rock-chips.com>,
        Ajay Kumar <ajaykumar.rs@samsung.com>,
        Vincent Palatin <vpalatin@chromium.org>,
        cawa.cheng@mediatek.com,
        Russell King <rmk+kernel@arm.linux.org.uk>,
        Thierry Reding <treding@nvidia.com>,
        devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org,
        yingjoe.chen@mediatek.com, eddie.huang@mediatek.com,
        linux-arm-kernel@lists.infradead.org,
        Rahul Sharma <rahul.sharma@samsung.com>,
        srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org,
        Sascha Hauer <kernel@pengutronix.de>,
        Sean Paul <seanpaul@chromium.org>
Subject: Re: [2/2] drm/panel: support for BOE tv101wum-n16 wuxga dsi video
 mode panel
Message-ID: <20190609105338.GB28935@ravnborg.org>
References: <20190608070230.55381-1-jitao.shi@mediatek.com>
 <20190608070230.55381-2-jitao.shi@mediatek.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190608070230.55381-2-jitao.shi@mediatek.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-CMAE-Score: 0
X-CMAE-Analysis: v=2.3 cv=dqr19Wo4 c=1 sm=1 tr=0
        a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17
        a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=mpaa-ttXAAAA:8
        a=e5mUnYsNAAAA:8 a=Ix8UOrJOzd6FWXjSbkEA:9 a=CjuIK1q_8ugA:10
        a=6heAxKwa5pAsJatQ0mat:22 a=Vxmtnl_E_bksehYqCbjh:22
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jitao.

Thanks for this new nice driver - a few comments follows.

	Sam

On Sat, Jun 08, 2019 at 03:02:30PM +0800, Jitao Shi wrote:
> Add driver for BOE tv101wum-nl6 panel is a 10.1" 1200x1920 panel.

Like in the binding there is some confusion between nl6 versus n16.
Here the subject says one thing, and the changelogn another thing.

> 
> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> ---
>  drivers/gpu/drm/panel/Kconfig                 |  10 +
>  drivers/gpu/drm/panel/Makefile                |   1 +
>  .../gpu/drm/panel/panel-boe-tv101wum-nl6.c    | 700 ++++++++++++++++++
>  3 files changed, 711 insertions(+)
>  create mode 100644 drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> 
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index e36dbb4df867..5dad028e35f0 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -272,4 +272,14 @@ config DRM_PANEL_TRULY_NT35597_WQXGA
>  	help
>  	  Say Y here if you want to enable support for Truly NT35597 WQXGA Dual DSI
>  	  Video Mode panel
> +
> +config DRM_PANEL_BOE_TV101WUM_NL6
> +	tristate "BOE TV101WUM 1200x1920 panel"
> +	depends on OF
> +	depends on DRM_MIPI_DSI
> +	depends on BACKLIGHT_CLASS_DEVICE
> +	help
> +	  Say Y here if you want to support for BOE TV101WUM WUXGA PANEL
> +	  DSI Video Mode panel
> +
New panel CONFIG symbols are added in alphabetically order.

>  endmenu
> diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile
> index 78e3dc376bdd..fc5944231aa8 100644
> --- a/drivers/gpu/drm/panel/Makefile
> +++ b/drivers/gpu/drm/panel/Makefile
> @@ -28,3 +28,4 @@ obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7701) += panel-sitronix-st7701.o
>  obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7789V) += panel-sitronix-st7789v.o
>  obj-$(CONFIG_DRM_PANEL_TPO_TPG110) += panel-tpo-tpg110.o
>  obj-$(CONFIG_DRM_PANEL_TRULY_NT35597_WQXGA) += panel-truly-nt35597.o
> +obj-$(CONFIG_DRM_PANEL_BOE_TV101WUM_NL6) += panel-boe-tv101wum-nl6.o

Drivers are added in alphabetically order after their CONFIG symbol.

> diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> new file mode 100644
> index 000000000000..19590664c337
> --- /dev/null
> +++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> @@ -0,0 +1,700 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2018 MediaTek Inc.
> + * Author: Jitao Shi <jitao.shi@mediatek.com>
> + */
> +
> +#include <linux/backlight.h>
> +#include <linux/gpio/consumer.h>
> +#include <linux/module.h>
> +#include <linux/of.h>
> +#include <linux/regulator/consumer.h>
> +
> +#include <drm/drmP.h>
drmP.h is deprecated - do not use in new drivers.

> +#include <drm/drm_crtc.h>
> +#include <drm/drm_mipi_dsi.h>
> +#include <drm/drm_panel.h>
> +
> +#include <video/mipi_display.h>
> +
> +struct boe_panel {
> +	struct drm_panel base;
> +	struct mipi_dsi_device *dsi;
> +
> +	struct backlight_device *backlight;
> +	struct regulator *pp1800;
> +	struct regulator *avee;
> +	struct regulator *avdd;
> +	struct gpio_desc *enable_gpio;
> +
> +	bool prepared;
> +	bool enabled;
> +
> +	const struct drm_display_mode *mode;
> +};
> +
> +enum dsi_cmd_type {
> +	INIT_GENENIC_CMD,
> +	INIT_DCS_CMD,
> +	DELAY_CMD,
> +};
> +
> +struct panel_init_cmd {
> +	enum dsi_cmd_type type;
> +	size_t len;
> +	const char *data;
> +};
> +
> +#define _INIT_CMD(...) { \
> +	.type = INIT_GENENIC_CMD,\
> +	.len = sizeof((char[]){__VA_ARGS__}), \
> +	.data = (char[]){__VA_ARGS__} }
> +
> +#define _INIT_DCS_CMD(...) { \
> +	.type = INIT_DCS_CMD, \
> +	.len = sizeof((char[]){__VA_ARGS__}), \
> +	.data = (char[]){__VA_ARGS__} }
> +
> +#define _INIT_DELAY_CMD(...) { \
> +	.type = DELAY_CMD,\
> +	.len = sizeof((char[]){__VA_ARGS__}), \
> +	.data = (char[]){__VA_ARGS__} }
> +
> +static const struct panel_init_cmd boe_init_cmd[] = {
In the following there are some empty lines.
If they have any semantic purpose please add a comment.
If not, then drop the empty lines.
> +	_INIT_DELAY_CMD(24),
> +	_INIT_DCS_CMD(0xB0, 0x05),
> +	_INIT_DCS_CMD(0xB1, 0xE5),
> +	_INIT_DCS_CMD(0xB3, 0x52),
> +
> +	_INIT_DCS_CMD(0xB0, 0x00),
> +	_INIT_DCS_CMD(0xB3, 0x88),
> +	_INIT_DCS_CMD(0xB0, 0x04),
> +	_INIT_DCS_CMD(0xB8, 0x00),
> +
> +	_INIT_DCS_CMD(0xB0, 0x00),
> +	_INIT_DCS_CMD(0xB6, 0x03),
> +	_INIT_DCS_CMD(0xBA, 0x8B),
> +	_INIT_DCS_CMD(0xBF, 0x1A),
> +	_INIT_DCS_CMD(0xC0, 0x0F),
> +	_INIT_DCS_CMD(0xC2, 0x0C),
> +	_INIT_DCS_CMD(0xC3, 0x02),
> +	_INIT_DCS_CMD(0xC4, 0x0C),
> +	_INIT_DCS_CMD(0xC5, 0x02),
> +
> +	_INIT_DCS_CMD(0xB0, 0x01),
> +	_INIT_DCS_CMD(0xE0, 0x26),
> +	_INIT_DCS_CMD(0xE1, 0x26),
> +	_INIT_DCS_CMD(0xDC, 0x00),
> +	_INIT_DCS_CMD(0xDD, 0x00),
> +	_INIT_DCS_CMD(0xCC, 0x26),
> +	_INIT_DCS_CMD(0xCD, 0x26),
> +	_INIT_DCS_CMD(0xC8, 0x00),
> +	_INIT_DCS_CMD(0xC9, 0x00),
> +	_INIT_DCS_CMD(0xD2, 0x03),
> +	_INIT_DCS_CMD(0xD3, 0x03),
> +	_INIT_DCS_CMD(0xE6, 0x04),
> +	_INIT_DCS_CMD(0xE7, 0x04),
> +	_INIT_DCS_CMD(0xC4, 0x09),
> +	_INIT_DCS_CMD(0xC5, 0x09),
> +	_INIT_DCS_CMD(0xD8, 0x0A),
> +	_INIT_DCS_CMD(0xD9, 0x0A),
> +	_INIT_DCS_CMD(0xC2, 0x0B),
> +	_INIT_DCS_CMD(0xC3, 0x0B),
> +	_INIT_DCS_CMD(0xD6, 0x0C),
> +	_INIT_DCS_CMD(0xD7, 0x0C),
> +	_INIT_DCS_CMD(0xC0, 0x05),
> +	_INIT_DCS_CMD(0xC1, 0x05),
> +	_INIT_DCS_CMD(0xD4, 0x06),
> +	_INIT_DCS_CMD(0xD5, 0x06),
> +	_INIT_DCS_CMD(0xCA, 0x07),
> +	_INIT_DCS_CMD(0xCB, 0x07),
> +	_INIT_DCS_CMD(0xDE, 0x08),
> +	_INIT_DCS_CMD(0xDF, 0x08),
> +
> +	_INIT_DCS_CMD(0xB0, 0x02),
> +	_INIT_DCS_CMD(0xC0, 0x00),
> +	_INIT_DCS_CMD(0xC1, 0x0D),
> +	_INIT_DCS_CMD(0xC2, 0x17),
> +	_INIT_DCS_CMD(0xC3, 0x26),
> +	_INIT_DCS_CMD(0xC4, 0x31),
> +	_INIT_DCS_CMD(0xC5, 0x1C),
> +	_INIT_DCS_CMD(0xC6, 0x2C),
> +	_INIT_DCS_CMD(0xC7, 0x33),
> +	_INIT_DCS_CMD(0xC8, 0x31),
> +	_INIT_DCS_CMD(0xC9, 0x37),
> +	_INIT_DCS_CMD(0xCA, 0x37),
> +	_INIT_DCS_CMD(0xCB, 0x37),
> +	_INIT_DCS_CMD(0xCC, 0x39),
> +	_INIT_DCS_CMD(0xCD, 0x2E),
> +	_INIT_DCS_CMD(0xCE, 0x2F),
> +	_INIT_DCS_CMD(0xCF, 0x2F),
> +	_INIT_DCS_CMD(0xD0, 0x07),
> +	_INIT_DCS_CMD(0xD2, 0x00),
> +	_INIT_DCS_CMD(0xD3, 0x0D),
> +	_INIT_DCS_CMD(0xD4, 0x17),
> +	_INIT_DCS_CMD(0xD5, 0x26),
> +	_INIT_DCS_CMD(0xD6, 0x31),
> +	_INIT_DCS_CMD(0xD7, 0x3F),
> +	_INIT_DCS_CMD(0xD8, 0x3F),
> +	_INIT_DCS_CMD(0xD9, 0x3F),
> +	_INIT_DCS_CMD(0xDA, 0x3F),
> +	_INIT_DCS_CMD(0xDB, 0x37),
> +	_INIT_DCS_CMD(0xDC, 0x37),
> +	_INIT_DCS_CMD(0xDD, 0x37),
> +	_INIT_DCS_CMD(0xDE, 0x39),
> +	_INIT_DCS_CMD(0xDF, 0x2E),
> +	_INIT_DCS_CMD(0xE0, 0x2F),
> +	_INIT_DCS_CMD(0xE1, 0x2F),
> +	_INIT_DCS_CMD(0xE2, 0x07),
> +
> +	_INIT_DCS_CMD(0xB0, 0x03),
> +	_INIT_DCS_CMD(0xC8, 0x0B),
> +	_INIT_DCS_CMD(0xC9, 0x07),
> +	_INIT_DCS_CMD(0xC3, 0x00),
> +	_INIT_DCS_CMD(0xE7, 0x00),
> +	_INIT_DCS_CMD(0xC5, 0x2A),
> +	_INIT_DCS_CMD(0xDE, 0x2A),
> +	_INIT_DCS_CMD(0xCA, 0x43),
> +	_INIT_DCS_CMD(0xC9, 0x07),
> +	_INIT_DCS_CMD(0xE4, 0xC0),
> +	_INIT_DCS_CMD(0xE5, 0x0D),
> +	_INIT_DCS_CMD(0xCB, 0x00),
> +
> +	_INIT_DCS_CMD(0xB0, 0x06),
> +	_INIT_DCS_CMD(0xB8, 0xA5),
> +	_INIT_DCS_CMD(0xC0, 0xA5),
> +	_INIT_DCS_CMD(0xC7, 0x0F),
> +	_INIT_DCS_CMD(0xD5, 0x32),
> +	_INIT_DCS_CMD(0xB8, 0x00),
> +	_INIT_DCS_CMD(0xC0, 0x00),
> +	_INIT_DCS_CMD(0xBC, 0x00),
> +
> +	_INIT_DCS_CMD(0xB0, 0x07),
> +	_INIT_DCS_CMD(0xB1, 0x00),
> +	_INIT_DCS_CMD(0xB2, 0x02),
> +	_INIT_DCS_CMD(0xB3, 0x0F),
> +	_INIT_DCS_CMD(0xB4, 0x25),
> +	_INIT_DCS_CMD(0xB5, 0x39),
> +	_INIT_DCS_CMD(0xB6, 0x4E),
> +	_INIT_DCS_CMD(0xB7, 0x72),
> +	_INIT_DCS_CMD(0xB8, 0x97),
> +	_INIT_DCS_CMD(0xB9, 0xDC),
> +	_INIT_DCS_CMD(0xBA, 0x22),
> +	_INIT_DCS_CMD(0xBB, 0xA4),
> +	_INIT_DCS_CMD(0xBC, 0x2B),
> +	_INIT_DCS_CMD(0xBD, 0x2F),
> +	_INIT_DCS_CMD(0xBE, 0xA9),
> +	_INIT_DCS_CMD(0xBF, 0x25),
> +	_INIT_DCS_CMD(0xC0, 0x61),
> +	_INIT_DCS_CMD(0xC1, 0x97),
> +	_INIT_DCS_CMD(0xC2, 0xB2),
> +	_INIT_DCS_CMD(0xC3, 0xCD),
> +	_INIT_DCS_CMD(0xC4, 0xD9),
> +	_INIT_DCS_CMD(0xC5, 0xE7),
> +	_INIT_DCS_CMD(0xC6, 0xF4),
> +	_INIT_DCS_CMD(0xC7, 0xFA),
> +	_INIT_DCS_CMD(0xC8, 0xFC),
> +	_INIT_DCS_CMD(0xC9, 0x00),
> +	_INIT_DCS_CMD(0xCA, 0x00),
> +	_INIT_DCS_CMD(0xCB, 0x16),
> +	_INIT_DCS_CMD(0xCC, 0xAF),
> +	_INIT_DCS_CMD(0xCD, 0xFF),
> +	_INIT_DCS_CMD(0xCE, 0xFF),
> +
> +	_INIT_DCS_CMD(0xB0, 0x08),
> +	_INIT_DCS_CMD(0xB1, 0x04),
> +	_INIT_DCS_CMD(0xB2, 0x05),
> +	_INIT_DCS_CMD(0xB3, 0x11),
> +	_INIT_DCS_CMD(0xB4, 0x24),
> +	_INIT_DCS_CMD(0xB5, 0x39),
> +	_INIT_DCS_CMD(0xB6, 0x4F),
> +	_INIT_DCS_CMD(0xB7, 0x72),
> +	_INIT_DCS_CMD(0xB8, 0x98),
> +	_INIT_DCS_CMD(0xB9, 0xDC),
> +	_INIT_DCS_CMD(0xBA, 0x23),
> +	_INIT_DCS_CMD(0xBB, 0xA6),
> +	_INIT_DCS_CMD(0xBC, 0x2C),
> +	_INIT_DCS_CMD(0xBD, 0x30),
> +	_INIT_DCS_CMD(0xBE, 0xAA),
> +	_INIT_DCS_CMD(0xBF, 0x26),
> +	_INIT_DCS_CMD(0xC0, 0x62),
> +	_INIT_DCS_CMD(0xC1, 0x9B),
> +	_INIT_DCS_CMD(0xC2, 0xB5),
> +	_INIT_DCS_CMD(0xC3, 0xCF),
> +	_INIT_DCS_CMD(0xC4, 0xDB),
> +	_INIT_DCS_CMD(0xC5, 0xE8),
> +	_INIT_DCS_CMD(0xC6, 0xF5),
> +	_INIT_DCS_CMD(0xC7, 0xFA),
> +	_INIT_DCS_CMD(0xC8, 0xFC),
> +	_INIT_DCS_CMD(0xC9, 0x00),
> +	_INIT_DCS_CMD(0xCA, 0x00),
> +	_INIT_DCS_CMD(0xCB, 0x16),
> +	_INIT_DCS_CMD(0xCC, 0xAF),
> +	_INIT_DCS_CMD(0xCD, 0xFF),
> +	_INIT_DCS_CMD(0xCE, 0xFF),
> +
> +	_INIT_DCS_CMD(0xB0, 0x09),
> +	_INIT_DCS_CMD(0xB1, 0x04),
> +	_INIT_DCS_CMD(0xB2, 0x02),
> +	_INIT_DCS_CMD(0xB3, 0x16),
> +	_INIT_DCS_CMD(0xB4, 0x24),
> +	_INIT_DCS_CMD(0xB5, 0x3B),
> +	_INIT_DCS_CMD(0xB6, 0x4F),
> +	_INIT_DCS_CMD(0xB7, 0x73),
> +	_INIT_DCS_CMD(0xB8, 0x99),
> +	_INIT_DCS_CMD(0xB9, 0xE0),
> +	_INIT_DCS_CMD(0xBA, 0x26),
> +	_INIT_DCS_CMD(0xBB, 0xAD),
> +	_INIT_DCS_CMD(0xBC, 0x36),
> +	_INIT_DCS_CMD(0xBD, 0x3A),
> +	_INIT_DCS_CMD(0xBE, 0xAE),
> +	_INIT_DCS_CMD(0xBF, 0x2A),
> +	_INIT_DCS_CMD(0xC0, 0x66),
> +	_INIT_DCS_CMD(0xC1, 0x9E),
> +	_INIT_DCS_CMD(0xC2, 0xB8),
> +	_INIT_DCS_CMD(0xC3, 0xD1),
> +	_INIT_DCS_CMD(0xC4, 0xDD),
> +	_INIT_DCS_CMD(0xC5, 0xE9),
> +	_INIT_DCS_CMD(0xC6, 0xF6),
> +	_INIT_DCS_CMD(0xC7, 0xFA),
> +	_INIT_DCS_CMD(0xC8, 0xFC),
> +	_INIT_DCS_CMD(0xC9, 0x00),
> +	_INIT_DCS_CMD(0xCA, 0x00),
> +	_INIT_DCS_CMD(0xCB, 0x16),
> +	_INIT_DCS_CMD(0xCC, 0xAF),
> +	_INIT_DCS_CMD(0xCD, 0xFF),
> +	_INIT_DCS_CMD(0xCE, 0xFF),
> +
> +	_INIT_DCS_CMD(0xB0, 0x0A),
> +	_INIT_DCS_CMD(0xB1, 0x00),
> +	_INIT_DCS_CMD(0xB2, 0x02),
> +	_INIT_DCS_CMD(0xB3, 0x0F),
> +	_INIT_DCS_CMD(0xB4, 0x25),
> +	_INIT_DCS_CMD(0xB5, 0x39),
> +	_INIT_DCS_CMD(0xB6, 0x4E),
> +	_INIT_DCS_CMD(0xB7, 0x72),
> +	_INIT_DCS_CMD(0xB8, 0x97),
> +	_INIT_DCS_CMD(0xB9, 0xDC),
> +	_INIT_DCS_CMD(0xBA, 0x22),
> +	_INIT_DCS_CMD(0xBB, 0xA4),
> +	_INIT_DCS_CMD(0xBC, 0x2B),
> +	_INIT_DCS_CMD(0xBD, 0x2F),
> +	_INIT_DCS_CMD(0xBE, 0xA9),
> +	_INIT_DCS_CMD(0xBF, 0x25),
> +	_INIT_DCS_CMD(0xC0, 0x61),
> +	_INIT_DCS_CMD(0xC1, 0x97),
> +	_INIT_DCS_CMD(0xC2, 0xB2),
> +	_INIT_DCS_CMD(0xC3, 0xCD),
> +	_INIT_DCS_CMD(0xC4, 0xD9),
> +	_INIT_DCS_CMD(0xC5, 0xE7),
> +	_INIT_DCS_CMD(0xC6, 0xF4),
> +	_INIT_DCS_CMD(0xC7, 0xFA),
> +	_INIT_DCS_CMD(0xC8, 0xFC),
> +	_INIT_DCS_CMD(0xC9, 0x00),
> +	_INIT_DCS_CMD(0xCA, 0x00),
> +	_INIT_DCS_CMD(0xCB, 0x16),
> +	_INIT_DCS_CMD(0xCC, 0xAF),
> +	_INIT_DCS_CMD(0xCD, 0xFF),
> +	_INIT_DCS_CMD(0xCE, 0xFF),
> +
> +	_INIT_DCS_CMD(0xB0, 0x0B),
> +	_INIT_DCS_CMD(0xB1, 0x04),
> +	_INIT_DCS_CMD(0xB2, 0x05),
> +	_INIT_DCS_CMD(0xB3, 0x11),
> +	_INIT_DCS_CMD(0xB4, 0x24),
> +	_INIT_DCS_CMD(0xB5, 0x39),
> +	_INIT_DCS_CMD(0xB6, 0x4F),
> +	_INIT_DCS_CMD(0xB7, 0x72),
> +	_INIT_DCS_CMD(0xB8, 0x98),
> +	_INIT_DCS_CMD(0xB9, 0xDC),
> +	_INIT_DCS_CMD(0xBA, 0x23),
> +	_INIT_DCS_CMD(0xBB, 0xA6),
> +	_INIT_DCS_CMD(0xBC, 0x2C),
> +	_INIT_DCS_CMD(0xBD, 0x30),
> +	_INIT_DCS_CMD(0xBE, 0xAA),
> +	_INIT_DCS_CMD(0xBF, 0x26),
> +	_INIT_DCS_CMD(0xC0, 0x62),
> +	_INIT_DCS_CMD(0xC1, 0x9B),
> +	_INIT_DCS_CMD(0xC2, 0xB5),
> +	_INIT_DCS_CMD(0xC3, 0xCF),
> +	_INIT_DCS_CMD(0xC4, 0xDB),
> +	_INIT_DCS_CMD(0xC5, 0xE8),
> +	_INIT_DCS_CMD(0xC6, 0xF5),
> +	_INIT_DCS_CMD(0xC7, 0xFA),
> +	_INIT_DCS_CMD(0xC8, 0xFC),
> +	_INIT_DCS_CMD(0xC9, 0x00),
> +	_INIT_DCS_CMD(0xCA, 0x00),
> +	_INIT_DCS_CMD(0xCB, 0x16),
> +	_INIT_DCS_CMD(0xCC, 0xAF),
> +	_INIT_DCS_CMD(0xCD, 0xFF),
> +	_INIT_DCS_CMD(0xCE, 0xFF),
> +
> +	_INIT_DCS_CMD(0xB0, 0x0C),
> +	_INIT_DCS_CMD(0xB1, 0x04),
> +	_INIT_DCS_CMD(0xB2, 0x02),
> +	_INIT_DCS_CMD(0xB3, 0x16),
> +	_INIT_DCS_CMD(0xB4, 0x24),
> +	_INIT_DCS_CMD(0xB5, 0x3B),
> +	_INIT_DCS_CMD(0xB6, 0x4F),
> +	_INIT_DCS_CMD(0xB7, 0x73),
> +	_INIT_DCS_CMD(0xB8, 0x99),
> +	_INIT_DCS_CMD(0xB9, 0xE0),
> +	_INIT_DCS_CMD(0xBA, 0x26),
> +	_INIT_DCS_CMD(0xBB, 0xAD),
> +	_INIT_DCS_CMD(0xBC, 0x36),
> +	_INIT_DCS_CMD(0xBD, 0x3A),
> +	_INIT_DCS_CMD(0xBE, 0xAE),
> +	_INIT_DCS_CMD(0xBF, 0x2A),
> +	_INIT_DCS_CMD(0xC0, 0x66),
> +	_INIT_DCS_CMD(0xC1, 0x9E),
> +	_INIT_DCS_CMD(0xC2, 0xB8),
> +	_INIT_DCS_CMD(0xC3, 0xD1),
> +	_INIT_DCS_CMD(0xC4, 0xDD),
> +	_INIT_DCS_CMD(0xC5, 0xE9),
> +	_INIT_DCS_CMD(0xC6, 0xF6),
> +	_INIT_DCS_CMD(0xC7, 0xFA),
> +	_INIT_DCS_CMD(0xC8, 0xFC),
> +	_INIT_DCS_CMD(0xC9, 0x00),
> +	_INIT_DCS_CMD(0xCA, 0x00),
> +	_INIT_DCS_CMD(0xCB, 0x16),
> +	_INIT_DCS_CMD(0xCC, 0xAF),
> +	_INIT_DCS_CMD(0xCD, 0xFF),
> +	_INIT_DCS_CMD(0xCE, 0xFF),
> +
> +	_INIT_DCS_CMD(0xB0, 0x00),
> +	_INIT_DCS_CMD(0xB3, 0x08),
> +	_INIT_DCS_CMD(0xB0, 0x04),
> +	_INIT_DCS_CMD(0xB8, 0x68),
> +	_INIT_DELAY_CMD(150),
> +	{},
> +};
> +
> +static inline struct boe_panel *to_boe_panel(struct drm_panel *panel)
> +{
> +	return container_of(panel, struct boe_panel, base);
> +}
> +
> +static int boe_panel_init(struct boe_panel *boe)
> +{
> +	struct mipi_dsi_device *dsi = boe->dsi;
> +	struct drm_panel *panel = &boe->base;
> +	int err, i;
> +
> +	for (i = 0; boe_init_cmd[i].len != 0; i++) {
> +		const struct panel_init_cmd *cmd = &boe_init_cmd[i];
> +
> +		switch (cmd->type) {
> +		case INIT_DCS_CMD:
> +			err = mipi_dsi_dcs_write(dsi, cmd->data[0],
> +						 (cmd->len <= 1) ? NULL :
> +						 &cmd->data[1], cmd->len - 1);
> +			break;
> +
> +		case DELAY_CMD:
> +			msleep(cmd->data[0]);
> +			err = 0;
> +			break;
> +
> +		case INIT_GENENIC_CMD:
> +		default:
> +			err = mipi_dsi_generic_write(dsi, cmd->data, cmd->len);
> +			break;
> +		}
> +
> +		if (err < 0) {
> +			dev_err(panel->dev,
> +				"failed to write command %u\n", i);
> +			return err;
> +		}
> +	}
> +
> +	return 0;
> +}
> +
> +static int boe_panel_off(struct boe_panel *boe)
> +{
> +	struct mipi_dsi_device *dsi = boe->dsi;
> +	int ret;
> +
> +	dsi->mode_flags &= ~MIPI_DSI_MODE_LPM;
> +
> +	ret = mipi_dsi_dcs_enter_sleep_mode(dsi);
> +	if (ret < 0)
> +		return ret;
> +
> +	return 0;
> +}
> +
> +static int boe_panel_disable(struct drm_panel *panel)
> +{
> +	struct boe_panel *boe = to_boe_panel(panel);
> +
> +	if (!boe->enabled)
> +		return 0;
> +
> +	backlight_disable(boe->backlight);
> +
> +	boe->enabled = false;
> +
> +	return 0;
> +}
> +
> +static int boe_panel_unprepare(struct drm_panel *panel)
> +{
> +	struct boe_panel *boe = to_boe_panel(panel);
> +	int ret;
> +
> +	if (!boe->prepared)
> +		return 0;
> +
> +	ret = boe_panel_off(boe);
> +	if (ret < 0) {
> +		dev_err(panel->dev, "failed to set panel off: %d\n", ret);
> +		return ret;
> +	}
> +
> +	msleep(150);
> +	if (boe->enable_gpio)
> +		gpiod_set_value(boe->enable_gpio, 0);
> +	usleep_range(500, 1000);
> +	regulator_disable(boe->avee);
> +	regulator_disable(boe->avdd);
> +	usleep_range(5000, 7000);
> +	regulator_disable(boe->pp1800);
> +
> +	boe->prepared = false;
> +
> +	return 0;
> +}
> +
> +static int boe_panel_prepare(struct drm_panel *panel)
> +{
> +	struct boe_panel *boe = to_boe_panel(panel);
> +	int ret;
> +
> +	if (boe->prepared)
> +		return 0;
> +
> +	if (boe->enable_gpio) {
> +		gpiod_set_value(boe->enable_gpio, 0);
> +		usleep_range(1000, 1500);
> +	}
> +
> +	ret = regulator_enable(boe->pp1800);
> +	if (ret < 0)
> +		return ret;
> +
> +	usleep_range(3000, 5000);
> +
> +	ret = regulator_enable(boe->avdd);
> +	if (ret < 0)
> +		goto poweroff1v8;
> +	ret = regulator_enable(boe->avee);
> +	if (ret < 0)
> +		goto poweroffavdd;
> +
> +	msleep(100);
> +
> +	if (boe->enable_gpio) {
> +		gpiod_set_value(boe->enable_gpio, 1);
> +		usleep_range(10000, 12000);
> +	}
> +
> +	ret = boe_panel_init(boe);
> +	if (ret < 0) {
> +		dev_err(panel->dev, "failed to init panel: %d\n", ret);
> +		goto poweroff;
> +	}
> +
> +	boe->prepared = true;
> +
> +	return 0;
> +
> +poweroff:
> +	regulator_disable(boe->avee);
> +poweroffavdd:
> +	regulator_disable(boe->avdd);
> +poweroff1v8:
> +	usleep_range(5000, 7000);
> +	regulator_disable(boe->pp1800);
> +	if (boe->enable_gpio)
> +		gpiod_set_value(boe->enable_gpio, 0);
> +	return ret;
> +}
> +
> +static int boe_panel_enable(struct drm_panel *panel)
> +{
> +	struct boe_panel *boe = to_boe_panel(panel);
> +	int ret;
> +
> +	if (boe->enabled)
> +		return 0;
> +
> +	ret = backlight_enable(boe->backlight);
> +	if (ret) {
> +		DRM_DEV_ERROR(panel->drm->dev,
> +			      "Failed to enable backlight %d\n", ret);

There is inconsistent use of logging.
One place uses dev_err(), and here DRM_DEV_ERROR().
I learned that neither are optimal, but for now stick with one way to do
it.

> +		return ret;
> +	}
> +
> +	boe->enabled = true;
> +
> +	return 0;
> +}
> +
> +static const struct drm_display_mode default_mode = {
> +	.clock = 159425,
> +	.hdisplay = 1200,
> +	.hsync_start = 1200 + 100,
> +	.hsync_end = 1200 + 100 + 40,
> +	.htotal = 1200 + 100 + 40 + 24,
> +	.vdisplay = 1920,
> +	.vsync_start = 1920 + 10,
> +	.vsync_end = 1920 + 10 + 14,
> +	.vtotal = 1920 + 10 + 14 + 4,
> +	.vrefresh = 60,
> +};
> +
> +static int boe_panel_get_modes(struct drm_panel *panel)
> +{
> +	struct drm_display_mode *mode;
> +
> +	mode = drm_mode_duplicate(panel->drm, &default_mode);
> +	if (!mode) {
> +		dev_err(panel->drm->dev, "failed to add mode %ux%ux@%u\n",
An extra x has sneaked in here.
wrong: "failed oo add mode %ux%ux@%u\n"
good:  "failed to add mode %ux%u@%u\n"

> +			default_mode.hdisplay, default_mode.vdisplay,
> +			default_mode.vrefresh);
> +		return -ENOMEM;
> +	}
> +
> +	drm_mode_set_name(mode);
> +
> +	drm_mode_probed_add(panel->connector, mode);
> +
> +	panel->connector->display_info.width_mm = 135;
> +	panel->connector->display_info.height_mm = 216;
> +	panel->connector->display_info.bpc = 8;
Please embed these constants in default_mde, and then read them from
there. So you avoid hardcoding display parameters in more places.

I think you should also add DRM_MODE_TYPE_PREFERRED - se other drivers.
> +
> +	return 1;
> +}
> +
> +static const struct drm_panel_funcs boe_panel_funcs = {
> +	.disable = boe_panel_disable,
> +	.unprepare = boe_panel_unprepare,
> +	.prepare = boe_panel_prepare,
> +	.enable = boe_panel_enable,
> +	.get_modes = boe_panel_get_modes,
> +};
> +
> +static int boe_panel_add(struct boe_panel *boe)
> +{
> +	struct device *dev = &boe->dsi->dev;
> +
> +	boe->avdd = devm_regulator_get(dev, "avdd");
> +	if (IS_ERR(boe->avdd))
> +		return PTR_ERR(boe->avdd);
> +
> +	boe->avee = devm_regulator_get(dev, "avee");
> +	if (IS_ERR(boe->avee))
> +		return PTR_ERR(boe->avee);
> +
> +	boe->pp1800 = devm_regulator_get(dev, "pp1800");
> +	if (IS_ERR(boe->pp1800))
> +		return PTR_ERR(boe->pp1800);
> +
> +	boe->enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_LOW);
> +	if (IS_ERR(boe->enable_gpio)) {
> +		dev_err(dev, "cannot get reset-gpios %ld\n",
> +			PTR_ERR(boe->enable_gpio));
> +		boe->enable_gpio = NULL;
> +	} else {
> +		gpiod_set_value(boe->enable_gpio, 0);
> +	}
The enable_gpio is mandatory according to the binding.
So if this is true then error out if missing.
And drop all code that hanle that enable_gpio is optionel.

> +
> +	boe->backlight = devm_of_find_backlight(dev);
> +	if (IS_ERR(boe->backlight))
> +		return PTR_ERR(boe->backlight);
> +
> +	drm_panel_init(&boe->base);
> +	boe->base.funcs = &boe_panel_funcs;
> +	boe->base.dev = &boe->dsi->dev;
> +
> +	return drm_panel_add(&boe->base);
> +}
> +
> +static void boe_panel_del(struct boe_panel *boe)
> +{
> +	if (boe->base.dev)
> +		drm_panel_remove(&boe->base);
> +}
The boe_panel_del() function only obscufates it. embed it in the only
caller.

> +
> +static int boe_panel_probe(struct mipi_dsi_device *dsi)
> +{
> +	struct boe_panel *boe;
> +	int ret;
> +
> +	dsi->lanes = 4;
> +	dsi->format = MIPI_DSI_FMT_RGB888;
> +	dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
> +		 MIPI_DSI_MODE_LPM;
> +
> +	boe = devm_kzalloc(&dsi->dev, sizeof(*boe), GFP_KERNEL);
> +	if (!boe)
> +		return -ENOMEM;
> +
> +	mipi_dsi_set_drvdata(dsi, boe);
> +
> +	boe->dsi = dsi;
> +
> +	ret = boe_panel_add(boe);
> +	if (ret < 0)
> +		return ret;
> +
> +	return mipi_dsi_attach(dsi);
> +}
> +
> +static int boe_panel_remove(struct mipi_dsi_device *dsi)
> +{
> +	struct boe_panel *boe = mipi_dsi_get_drvdata(dsi);
> +	int ret;
> +
> +	ret = boe_panel_disable(&boe->base);
> +	if (ret < 0)
> +		dev_err(&dsi->dev, "failed to disable panel: %d\n", ret);
> +
> +	ret = mipi_dsi_detach(dsi);
> +	if (ret < 0)
> +		dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", ret);
> +
> +	boe_panel_del(boe);
> +
> +	return 0;
> +}
> +
> +static void boe_panel_shutdown(struct mipi_dsi_device *dsi)
> +{
> +	struct boe_panel *boe = mipi_dsi_get_drvdata(dsi);
> +
> +	boe_panel_disable(&boe->base);
> +}
> +
> +static const struct of_device_id boe_of_match[] = {
> +	{ .compatible = "boe,tv101wum-nl6", },
> +	{ }
Some drivers use { /* sentinel */ } here.

> +};
> +MODULE_DEVICE_TABLE(of, boe_of_match);
> +
> +static struct mipi_dsi_driver boe_panel_driver = {
> +	.driver = {
> +		.name = "panel-boe-tv101wum-nl6",
> +		.of_match_table = boe_of_match,
> +	},
> +	.probe = boe_panel_probe,
> +	.remove = boe_panel_remove,
> +	.shutdown = boe_panel_shutdown,
> +};
> +module_mipi_dsi_driver(boe_panel_driver);
> +
> +MODULE_AUTHOR("Jitao Shi <jitao.shi@mediatek.com>");
> +MODULE_DESCRIPTION("BOE tv101wum-nl6 1200x1920 video mode panel driver");
> +MODULE_LICENSE("GPL v2");
> -- 
> 2.21.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel