From: Kirill Smelkov <kirr@nexedi.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: <stable@vger.kernel.org>, Sasha Levin <sashal@kernel.org>,
Ben Hutchings <ben@decadent.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
Miklos Szeredi <miklos@szeredi.hu>,
<linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4.14 0/2] Fix FUSE read/write deadlock on stream-like files
Date: Sun, 09 Jun 2019 17:10:28 +0000 [thread overview]
Message-ID: <20190609171020.GA27685@deco.navytux.spb.ru> (raw)
In-Reply-To: <20190609163826.GB26671@kroah.com>
On Sun, Jun 09, 2019 at 06:38:26PM +0200, Greg KH wrote:
> On Sun, Jun 09, 2019 at 12:39:08PM +0000, Kirill Smelkov wrote:
> > Hello stable team,
> >
> > Please consider applying the following 2 patches to Linux-4.14 stable
> > tree. The patches fix regression introduced in 3.14 where both read and
> > write started to run under lock taken, which resulted in FUSE (and many
> > other drivers) deadlocks for cases where stream-like files are used with
> > read and write being run simultaneously.
> >
> > Please see complete problem description in upstream commit 10dce8af3422
> > ("fs: stream_open - opener for stream-like files so that read and write
> > can run simultaneously without deadlock").
> >
> > The actual FUSE fix (upstream commit bbd84f33652f "fuse: Add
> > FOPEN_STREAM to use stream_open()") was merged into 5.2 with `Cc:
> > stable@vger.kernel.org # v3.14+` mark and is already included into 5.1,
> > 5.0 and 4.19 stable trees. However for some reason it is not (yet ?)
> > included into 4.14, 4.9, 4.4, 3.18 and 3.16 trees.
> >
> > The patches fix a real problem into which my FUSE filesystem ran, and
> > which also likely affects OSSPD (full details are in the patches
> > description). Please consider including the fixes into 4.14 (as well as
> > into earlier stable trees - I will send corresponding series separately -
> > - one per tree).
>
> Many thanks for these. I've queued up all but the 3.16 patches (those
> are for Ben).
>
> I hadn't done the backport yet, as I didn't know how "severe" this was,
> and didn't have the time to do it. Thanks for making it easy :)
Greg, you are welcome and thanks a lot for feedback and for queueing the
patches. Ben, looking forward to 3.16 update to care about Jessie.
Thanks again,
Kirill
prev parent reply other threads:[~2019-06-09 17:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-09 12:39 Kirill Smelkov
2019-06-09 12:39 ` [PATCH 4.14 1/2] fs: stream_open - opener for stream-like files so that read and write can run simultaneously without deadlock Kirill Smelkov
2019-06-09 12:39 ` [PATCH 4.14 2/2] fuse: Add FOPEN_STREAM to use stream_open() Kirill Smelkov
2019-06-09 16:38 ` [PATCH 4.14 0/2] Fix FUSE read/write deadlock on stream-like files Greg KH
2019-06-09 17:10 ` Kirill Smelkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190609171020.GA27685@deco.navytux.spb.ru \
--to=kirr@nexedi.com \
--cc=ben@decadent.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®