From: Christian Brauner <christian@brauner.io>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
bridge@lists.linux-foundation.org, tyhicks@canonical.com,
kadlec@blackhole.kfki.hu, fw@strlen.de,
roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com,
linux-kernel@vger.kernel.org, richardrose@google.com,
vapier@chromium.org, bhthompson@google.com,
smbarber@chromium.org, joelhockey@chromium.org,
ueberall@themenzentrisch.de
Subject: Re: [PATCH net-next v1 1/1] br_netfilter: namespace bridge netfilter sysctls
Date: Mon, 10 Jun 2019 22:51:36 +0200 [thread overview]
Message-ID: <20190610205134.6wqparmtsdzbiutv@brauner.io> (raw)
In-Reply-To: <20190610174136.p3fbcbn33en5bb7f@salvia>
On Mon, Jun 10, 2019 at 07:41:36PM +0200, Pablo Neira Ayuso wrote:
> Thanks for updating this patch to use struct brnf_net.
>
> A few comments below.
>
> On Sun, Jun 09, 2019 at 06:23:04PM +0200, Christian Brauner wrote:
> [...]
> > diff --git a/include/net/netfilter/br_netfilter.h b/include/net/netfilter/br_netfilter.h
> > index 89808ce293c4..302fcd3aade2 100644
> > --- a/include/net/netfilter/br_netfilter.h
> > +++ b/include/net/netfilter/br_netfilter.h
> > @@ -85,17 +82,42 @@ static inline __be16 vlan_proto(const struct sk_buff *skb)
> > return 0;
> > }
> >
> > -#define IS_VLAN_IP(skb) \
> > - (vlan_proto(skb) == htons(ETH_P_IP) && \
> > - brnf_filter_vlan_tagged)
> > +static inline bool is_vlan_ip(const struct sk_buff *skb, const struct net *net)
> > +{
>
> I like this conversion from macro to static inline a lot.
>
> But if you let me ask for one more change, would you split this in two
> patches? One to replace #defines by static inline.
Sure.
prev parent reply other threads:[~2019-06-10 20:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-09 16:23 [PATCH net-next v1 0/1] br_netfilter: enable in non-initial netns Christian Brauner
2019-06-09 16:23 ` [PATCH net-next v1 1/1] br_netfilter: namespace bridge netfilter sysctls Christian Brauner
2019-06-10 17:41 ` Pablo Neira Ayuso
2019-06-10 20:51 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190610205134.6wqparmtsdzbiutv@brauner.io \
--to=christian@brauner.io \
--cc=bhthompson@google.com \
--cc=bridge@lists.linux-foundation.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=joelhockey@chromium.org \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=pablo@netfilter.org \
--cc=richardrose@google.com \
--cc=roopa@cumulusnetworks.com \
--cc=smbarber@chromium.org \
--cc=tyhicks@canonical.com \
--cc=ueberall@themenzentrisch.de \
--cc=vapier@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®