From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAE1DC4321A for ; Tue, 11 Jun 2019 12:46:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 760502089E for ; Tue, 11 Jun 2019 12:46:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389023AbfFKMqq (ORCPT ); Tue, 11 Jun 2019 08:46:46 -0400 Received: from foss.arm.com ([217.140.110.172]:60506 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387593AbfFKMqq (ORCPT ); Tue, 11 Jun 2019 08:46:46 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9E1EA344; Tue, 11 Jun 2019 05:46:45 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2D29B3F557; Tue, 11 Jun 2019 05:46:44 -0700 (PDT) Date: Tue, 11 Jun 2019 13:46:42 +0100 From: Mark Rutland To: Julien Thierry Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, rostedt@goodmis.org, marc.zyngier@arm.com, yuzenghui@huawei.com, wanghaibin.wang@huawei.com, james.morse@arm.com, will.deacon@arm.com, catalin.marinas@arm.com, liwei391@huawei.com Subject: Re: [PATCH v4 2/8] arm64: irqflags: Pass flags as readonly operand to restore instruction Message-ID: <20190611124641.GB29008@lakrids.cambridge.arm.com> References: <1560245893-46998-1-git-send-email-julien.thierry@arm.com> <1560245893-46998-3-git-send-email-julien.thierry@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1560245893-46998-3-git-send-email-julien.thierry@arm.com> User-Agent: Mutt/1.11.1+11 (2f07cb52) (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 11, 2019 at 10:38:07AM +0100, Julien Thierry wrote: > Flags are only read by the instructions doing the irqflags restore > operation. Pass the operand as read only to the asm inline instead of > read-write. > > Signed-off-by: Julien Thierry > Cc: Catalin Marinas > Cc: Will Deacon Acked-by: Mark Rutland Mark. > --- > arch/arm64/include/asm/irqflags.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/include/asm/irqflags.h b/arch/arm64/include/asm/irqflags.h > index 62996318..9c93152 100644 > --- a/arch/arm64/include/asm/irqflags.h > +++ b/arch/arm64/include/asm/irqflags.h > @@ -119,8 +119,8 @@ static inline void arch_local_irq_restore(unsigned long flags) > __msr_s(SYS_ICC_PMR_EL1, "%0") > "dsb sy", > ARM64_HAS_IRQ_PRIO_MASKING) > - : "+r" (flags) > : > + : "r" (flags) > : "memory"); > } > > -- > 1.9.1