From: Peter Zijlstra <peterz@infradead.org>
To: bsegall@google.com
Cc: linux-kernel@vger.kernel.org,
Xunlei Pang <xlpang@linux.alibaba.com>,
Ingo Molnar <mingo@redhat.com>, Phil Auld <pauld@redhat.com>
Subject: Re: [PATCH v2] sched/fair: don't push cfs_bandwith slack timers forward
Date: Tue, 11 Jun 2019 15:53:25 +0200 [thread overview]
Message-ID: <20190611135325.GY3436@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <xm26a7euy6iq.fsf_-_@bsegall-linux.svl.corp.google.com>
On Thu, Jun 06, 2019 at 10:21:01AM -0700, bsegall@google.com wrote:
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index efa686eeff26..60219acda94b 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -356,6 +356,7 @@ struct cfs_bandwidth {
> u64 throttled_time;
>
> bool distribute_running;
> + bool slack_started;
> #endif
> };
I'm thinking we can this instead? afaict both idle and period_active are
already effecitively booleans and don't need the full 16 bits.
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -338,8 +338,10 @@ struct cfs_bandwidth {
u64 runtime_expires;
int expires_seq;
- short idle;
- short period_active;
+ u8 idle;
+ u8 period_active;
+ u8 distribute_running;
+ u8 slack_started;
struct hrtimer period_timer;
struct hrtimer slack_timer;
struct list_head throttled_cfs_rq;
@@ -348,9 +350,6 @@ struct cfs_bandwidth {
int nr_periods;
int nr_throttled;
u64 throttled_time;
-
- bool distribute_running;
- bool slack_started;
#endif
};
next prev parent reply other threads:[~2019-06-11 13:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <xm26ef47yeyh.fsf@bsegall-linux.svl.corp.google.com>
2019-06-06 14:11 ` [PATCH] " Xunlei Pang
2019-06-06 17:21 ` [PATCH v2] " bsegall
2019-06-11 13:04 ` Phil Auld
2019-06-11 13:50 ` Peter Zijlstra
2019-06-11 13:53 ` Peter Zijlstra [this message]
2019-06-11 14:12 ` Phil Auld
2019-06-11 14:24 ` Peter Zijlstra
2019-06-11 15:06 ` Phil Auld
2019-06-11 17:26 ` bsegall
2019-06-17 14:22 ` [tip:sched/core] sched/fair: Don't " tip-bot for bsegall@google.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190611135325.GY3436@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bsegall@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pauld@redhat.com \
--cc=xlpang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome