From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66B90C0650E for ; Tue, 11 Jun 2019 17:40:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 444092173E for ; Tue, 11 Jun 2019 17:40:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560274812; bh=7PcY0EB4mUu+r7OtLkjmpV2IMEEFbqL3M5c9HsmDC2o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=fhmmNJhj7cC72juger3mqZO2oUYf7PFer8IegrS8kxplDurvBxe9nYQuhLI72ZnBZ 4GglePUbmXpzUKvZYOrucDBLQnfHdZOSb5RvzLbUxTqPiLRU7jFCPyrr1D+Z4yAjKK hOfhYSpzIW3O59KL2FOYOxL61Tyswe8wv+s0b9PE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406292AbfFKRkL (ORCPT ); Tue, 11 Jun 2019 13:40:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:39824 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406516AbfFKRkK (ORCPT ); Tue, 11 Jun 2019 13:40:10 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5ADC121734; Tue, 11 Jun 2019 17:40:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560274809; bh=7PcY0EB4mUu+r7OtLkjmpV2IMEEFbqL3M5c9HsmDC2o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hilj4TLKJUBRur0VtMtD1jRI59k82d/x3tlS47V0p3Ewyq6faSWP2wRMyjZeeiKNv JHsuqb9RSeMTtIIJlQHRxgbSPXWliKarZrjZ5KnaKoy0mHJomejexmT8s/T/51J3hz JFkxQODOJOqrOoV0cLrC6i8lLgQS1ECa5Hegm4Rg= Date: Tue, 11 Jun 2019 19:40:06 +0200 From: Greg Kroah-Hartman To: Daniel Vetter Cc: Sven Joachim , stable , Linux Kernel Mailing List , Dave Airlie Subject: Re: Linux 5.1.9 build failure with CONFIG_NOUVEAU_LEGACY_CTX_SUPPORT=n Message-ID: <20190611174006.GB31662@kroah.com> References: <87k1dsjkdo.fsf@turtle.gmx.de> <20190611153656.GA5084@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 11, 2019 at 07:33:16PM +0200, Daniel Vetter wrote: > On Tue, Jun 11, 2019 at 5:37 PM Greg Kroah-Hartman > wrote: > > On Tue, Jun 11, 2019 at 03:56:35PM +0200, Sven Joachim wrote: > > > Commit 1e07d63749 ("drm/nouveau: add kconfig option to turn off nouveau > > > legacy contexts. (v3)") has caused a build failure for me when I > > > actually tried that option (CONFIG_NOUVEAU_LEGACY_CTX_SUPPORT=n): > > > > > > ,---- > > > | Kernel: arch/x86/boot/bzImage is ready (#1) > > > | Building modules, stage 2. > > > | MODPOST 290 modules > > > | ERROR: "drm_legacy_mmap" [drivers/gpu/drm/nouveau/nouveau.ko] undefined! > > > | scripts/Makefile.modpost:91: recipe for target '__modpost' failed > > > `---- > > Calling drm_legacy_mmap is definitely not a great idea. I think either > we need a custom patch to remove that out on older kernels, or maybe > even #ifdef if you want to be super paranoid about breaking stuff ... > > > > Upstream does not have that problem, as commit bed2dd8421 ("drm/ttm: > > > Quick-test mmap offset in ttm_bo_mmap()") has removed the use of > > > drm_legacy_mmap from nouveau_ttm.c. Unfortunately that commit does not > > > apply in 5.1.9. > > > > > > Most likely 4.19.50 and 4.14.125 are also affected, I haven't tested > > > them yet. > > > > They probably are. > > > > Should I just revert this patch in the stable tree, or add some other > > patch (like the one pointed out here, which seems an odd patch for > > stable...) > > ... or backport the above patch, that should be save to do too. Not > sure what stable folks prefer? The above patch does not apply to all of the stable branches, so how about I just revert this? People can live with this option not able to turn off for now, and if they really want it, they can use a newer kernel, right? thanks, greg k-h