From: Borislav Petkov <bp@alien8.de>
To: "Yu, Fenghua" <fenghua.yu@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, H Peter Anvin <hpa@zytor.com>,
"Shankar, Ravi V" <ravi.v.shankar@intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>
Subject: Re: [RFC PATCH] x86/cpufeatures: Enumerate new AVX512 bfloat16 instructions
Date: Wed, 12 Jun 2019 05:59:08 +0200 [thread overview]
Message-ID: <20190612035908.GB32652@zn.tnic> (raw)
In-Reply-To: <3E5A0FA7E9CA944F9D5414FEC6C712209D8F4253@ORSMSX106.amr.corp.intel.com>
On Wed, Jun 12, 2019 at 03:29:57AM +0000, Yu, Fenghua wrote:
> My bad. I studied a bit more and found the patch #1 is not needed.
Why, I think you were spot-on:
"And the two variables are ONLY used in resctrl monitoring
configuration. There is no need to store them in cpuinfo_x86 on each
CPU."
That was a real overkill to put them in cpuinfo_x86. The information
needed should simply be read out in rdt_get_mon_l3_config() and that's
it - no need to global values to store them.
Now removing them should be in a separate patch so that review is easy.
Or am I missing an aspect?
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2019-06-12 3:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 17:02 Fenghua Yu
2019-06-10 19:20 ` Borislav Petkov
2019-06-11 18:19 ` Fenghua Yu
2019-06-11 19:47 ` Borislav Petkov
2019-06-11 22:28 ` Fenghua Yu
2019-06-12 3:29 ` Yu, Fenghua
2019-06-12 3:59 ` Borislav Petkov [this message]
2019-06-12 17:41 ` Fenghua Yu
2019-06-12 3:32 ` Fenghua Yu
2019-06-12 4:02 ` Borislav Petkov
2019-06-12 14:10 ` Sean Christopherson
2019-06-12 17:04 ` Fenghua Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612035908.GB32652@zn.tnic \
--to=bp@alien8.de \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=ravi.v.shankar@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®