From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: davem@davemloft.net, "Pablo Neira Ayuso" <pablo@netfilter.org>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Jiri Pirko" <jiri@mellanox.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Antoine Tenart" <antoine.tenart@bootlin.com>,
thomas.petazzoni@bootlin.com,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"Toshiaki Makita" <toshiaki.makita1@gmail.com>
Subject: Re: [PATCH net v2] net: ethtool: Allow matching on vlan DEI bit
Date: Wed, 12 Jun 2019 11:06:20 -0700 [thread overview]
Message-ID: <20190612110620.5f1653bc@cakuba.netronome.com> (raw)
In-Reply-To: <20190612151838.7455-1-maxime.chevallier@bootlin.com>
On Wed, 12 Jun 2019 17:18:38 +0200, Maxime Chevallier wrote:
> Using ethtool, users can specify a classification action matching on the
> full vlan tag, which includes the DEI bit (also previously called CFI).
>
> However, when converting the ethool_flow_spec to a flow_rule, we use
> dissector keys to represent the matching patterns.
>
> Since the vlan dissector key doesn't include the DEI bit, this
> information was silently discarded when translating the ethtool
> flow spec in to a flow_rule.
>
> This commit adds the DEI bit into the vlan dissector key, and allows
> propagating the information to the driver when parsing the ethtool flow
> spec.
>
> Fixes: eca4205f9ec3 ("ethtool: add ethtool_rx_flow_spec to flow_rule structure translator")
> Reported-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
LGTM, thanks!
prev parent reply other threads:[~2019-06-12 18:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 15:18 Maxime Chevallier
2019-06-12 17:10 ` David Miller
2019-06-12 18:06 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612110620.5f1653bc@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jiri@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=toshiaki.makita1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®