From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F18B5C31E46 for ; Wed, 12 Jun 2019 13:38:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C680D20B1F for ; Wed, 12 Jun 2019 13:38:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560346723; bh=zTTjXk6HPFKtrXGF56kPymN9VxXefIYOXj73DCi/m64=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=sUB/7uhKQO26i5EhdWduzz8HC0rlmCGqjqzzbh5WxqqchWTs8qiGDNE11rO2FRgt8 MOY80R8iCsbVySj11M8uXMcO10RiNh9+MVz4OBRoNwrfsTEro5OEDb3b91/JMP4oxp pORjtWiTs1XeGdw1JPCvN0UTmFFmtbleAktPqy20= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731950AbfFLNin (ORCPT ); Wed, 12 Jun 2019 09:38:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:57256 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726822AbfFLNim (ORCPT ); Wed, 12 Jun 2019 09:38:42 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A8092208CA; Wed, 12 Jun 2019 13:38:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560346722; bh=zTTjXk6HPFKtrXGF56kPymN9VxXefIYOXj73DCi/m64=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BX9y7BKHsJp8BM8+tDxmPbBtpXd/P6njt64f1QZYq2tv//bttARdhDk/n0n1uNXQ0 yPme7uNodBGe7RnUNUO8iKHVTmgcZNJDU4uUyAOOAMuo3jktacyzIhJprKiP4oftae b4F9yv4nF1UinRGsle9GoTXcj1a6b9Vf4zONYrrg= Date: Wed, 12 Jun 2019 15:38:38 +0200 From: Greg KH To: Gen Zhang Cc: nico@fluxnic.net, kilobyte@angband.pl, textshell@uchuujin.de, mpatocka@redhat.com, daniel.vetter@ffwll.ch, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] vt: fix a missing-check bug in con_init() Message-ID: <20190612133838.GA7748@kroah.com> References: <20190612131506.GA3526@zhanggen-UX430UQ> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190612131506.GA3526@zhanggen-UX430UQ> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 12, 2019 at 09:15:06PM +0800, Gen Zhang wrote: > In function con_init(), the pointer variable vc_cons[currcons].d, vc and > vc->vc_screenbuf is allocated by kzalloc(). However, kzalloc() returns > NULL when fails. Therefore, we should check the return value and handle > the error. > > Signed-off-by: Gen Zhang > --- What changed from v1, v2, and v3? That always goes below the --- line. v5 please. thanks, greg k-h