From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B96DC31E46 for ; Wed, 12 Jun 2019 14:59:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3BB1020866 for ; Wed, 12 Jun 2019 14:59:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439947AbfFLO75 (ORCPT ); Wed, 12 Jun 2019 10:59:57 -0400 Received: from verein.lst.de ([213.95.11.211]:60477 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2436945AbfFLO75 (ORCPT ); Wed, 12 Jun 2019 10:59:57 -0400 Received: by newverein.lst.de (Postfix, from userid 2005) id 1205768B02; Wed, 12 Jun 2019 16:59:27 +0200 (CEST) Date: Wed, 12 Jun 2019 16:59:26 +0200 From: Torsten Duwe To: Andrzej Hajda Cc: Maxime Ripard , Chen-Yu Tsai , Rob Herring , Mark Rutland , Thierry Reding , David Airlie , Daniel Vetter , Laurent Pinchart , Icenowy Zheng , Sean Paul , Vasily Khoruzhick , Harald Geyer , Greg Kroah-Hartman , Thomas Gleixner , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 6/7] dt-bindings: Add ANX6345 DP/eDP transmitter binding Message-ID: <20190612145926.GA28426@lst.de> References: <20190604122150.29D6468B05@newverein.lst.de> <20190604122305.07B9068B05@newverein.lst.de> <354de37d-57bb-6b06-c81a-a2081ea4f222@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <354de37d-57bb-6b06-c81a-a2081ea4f222@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 12, 2019 at 10:16:37AM +0200, Andrzej Hajda wrote: > > +The ANX6345 is an ultra-low power Full-HD eDP transmitter designed for > > +portable devices. > > + > > +Required properties: > > + > > + - compatible : "analogix,anx6345" > > + - reg : I2C address of the device > > + - reset-gpios : Which GPIO to use for reset > > > You have not specified it's active state, since in driver's code you > named it RESETN I guess it should be active low. Yes. The chip's reset is active low. > > > + - dvdd12-supply : Regulator for 1.2V digital core power. > > + - dvdd25-supply : Regulator for 2.5V digital core power. > > + - Video port for LVTTL input, using the DT bindings defined in [1]. > > > Please assign port number for input (I guess 0). True. > > > + > > +Optional properties: > > + > > + - Video port for eDP output (panel or connector) using the DT bindings > > + defined in [1]. > > > Shouldn't it be also required? See previous discussion. Surely there should be _something_ connected to the output side, but that something might not be relevant for the software side, so it might be omitted from the device tree. In fact, I'll submit v3 with the SPDX changes and without exactly this output port spec which had caused the heated discussion. Torsten