From: Borislav Petkov <bp@alien8.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Tony Luck <tony.luck@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>, Pu Wen <puwen@hygon.cn>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: mce: no need to check return value of debugfs_create functions
Date: Wed, 12 Jun 2019 17:18:56 +0200 [thread overview]
Message-ID: <20190612151856.GK32652@zn.tnic> (raw)
In-Reply-To: <20190612151531.GA16278@kroah.com>
On Wed, Jun 12, 2019 at 05:15:31PM +0200, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: <x86@kernel.org>
> Cc: Tony Luck <tony.luck@intel.com>
> Cc: Vishal Verma <vishal.l.verma@intel.com>
> Cc: Pu Wen <puwen@hygon.cn>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> arch/x86/kernel/cpu/mce/core.c | 16 +++++---------
> arch/x86/kernel/cpu/mce/inject.c | 34 +++++-------------------------
> arch/x86/kernel/cpu/mce/severity.c | 14 +++---------
> 3 files changed, 13 insertions(+), 51 deletions(-)
I think I'm having a deja-vu:
https://lkml.kernel.org/r/20190122215326.GM26587@zn.tnic
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2019-06-12 15:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 15:15 Greg Kroah-Hartman
2019-06-12 15:18 ` Borislav Petkov [this message]
2019-06-12 15:41 ` Greg Kroah-Hartman
2019-06-12 15:47 ` Borislav Petkov
2019-06-12 16:44 ` Greg Kroah-Hartman
2019-06-14 14:22 ` [tip:ras/core] x86/mce: Do not " tip-bot for Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612151856.GK32652@zn.tnic \
--to=bp@alien8.de \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=puwen@hygon.cn \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vishal.l.verma@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®