From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Xue Chaojing <xuechaojing@huawei.com>
Cc: <davem@davemloft.net>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <luoshaokai@huawei.com>,
<cloud.wangxiaoyun@huawei.com>, <chiqijun@huawei.com>,
<wulike1@huawei.com>
Subject: Re: [PATCH net-next v2 1/2] hinic: add rss support
Date: Wed, 12 Jun 2019 15:46:37 -0700 [thread overview]
Message-ID: <20190612154637.2ad4d882@cakuba.netronome.com> (raw)
In-Reply-To: <20190611181234.4843-2-xuechaojing@huawei.com>
On Tue, 11 Jun 2019 18:12:33 +0000, Xue Chaojing wrote:
> + for (i = 0; i < HINIC_RSS_INDIR_SIZE; i++)
> + indir_tbl[i] = (i / HINIC_RSS_INDIR_SIZE) * nic_dev->num_rss +
> + i % nic_dev->num_rss;
This looks suspicious:
i is in range [0, HINIC_RSS_INDIR_SIZE)
so i / HINIC_RSS_INDIR_SIZE is always 0
For the rest please use ethtool_rxfh_indir_default()
next prev parent reply other threads:[~2019-06-13 17:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 18:12 [PATCH net-next v2 0/2] hinic: add rss support and rss paramters configuration Xue Chaojing
2019-06-11 18:12 ` [PATCH net-next v2 1/2] hinic: add rss support Xue Chaojing
2019-06-12 22:46 ` Jakub Kicinski [this message]
2019-06-12 22:56 ` Jakub Kicinski
2019-06-13 3:16 ` xuechaojing
2019-06-11 18:12 ` [PATCH net-next v2 2/2] hinic: add support for rss parameters with ethtool Xue Chaojing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612154637.2ad4d882@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=chiqijun@huawei.com \
--cc=cloud.wangxiaoyun@huawei.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=luoshaokai@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=wulike1@huawei.com \
--cc=xuechaojing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®