From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B066C31E46 for ; Wed, 12 Jun 2019 17:03:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D85E421744 for ; Wed, 12 Jun 2019 17:03:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=nexedi.com header.i=kirr@nexedi.com header.b="qlDkCCC/"; dkim=pass (1024-bit key) header.d=mandrillapp.com header.i=@mandrillapp.com header.b="gyUQ2OA+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731170AbfFLRDJ (ORCPT ); Wed, 12 Jun 2019 13:03:09 -0400 Received: from mail177-30.suw61.mandrillapp.com ([198.2.177.30]:35904 "EHLO mail177-30.suw61.mandrillapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731040AbfFLRDI (ORCPT ); Wed, 12 Jun 2019 13:03:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=mandrill; d=nexedi.com; h=From:Subject:To:Cc:Message-Id:References:In-Reply-To:Date:MIME-Version:Content-Type:Content-Transfer-Encoding; i=kirr@nexedi.com; bh=Hm2gC+regS6aFJ0Z5S9VnOE8zeLWgmtCRNQHokPDkY8=; b=qlDkCCC/dPk74baVrVBLmOyLG+QU2eZx1SW9cdMEM2vAaKwb3Uj1ZVjG9dQUHZG7CqHgOKn2opNw zmxoR6WyKbtWnRPy0A3ja3InFo6aPJahQB5TCVqrIi/05h1Z+SbKhFGfSjJMOoHXrKFtPRyDFNDs sGOxzYm5BnXaxI0RabQ= Received: from pmta06.mandrill.prod.suw01.rsglab.com (127.0.0.1) by mail177-30.suw61.mandrillapp.com id h04o4m22rtkd for ; Wed, 12 Jun 2019 17:03:05 +0000 (envelope-from ) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; i=@mandrillapp.com; q=dns/txt; s=mandrill; t=1560358985; h=From : Subject : To : Cc : Message-Id : References : In-Reply-To : Date : MIME-Version : Content-Type : Content-Transfer-Encoding : From : Subject : Date : X-Mandrill-User : List-Unsubscribe; bh=Hm2gC+regS6aFJ0Z5S9VnOE8zeLWgmtCRNQHokPDkY8=; b=gyUQ2OA+FpqROVGuWEuouAFmLCuyTSCFEJiHlRTKoqy65wnR2sJIcjFX6zHmJTmBUjJUBd tCnYKV/guLBZNJGm9WNTM8TzJc3brbd9Ugs71cZMXWAcHd8uowf6wkBR8w/0ePcRTlWG6AVs GdTomTrpwS3dagPdbDPvj+LIn55Rg= From: Kirill Smelkov Subject: Re: [PATCH] fuse: require /dev/fuse reads to have enough buffer capacity (take 2) Received: from [87.98.221.171] by mandrillapp.com id 145d451a13654eaaa66dd24b26a9f854; Wed, 12 Jun 2019 17:03:05 +0000 To: Sander Eikelenboom Cc: Miklos Szeredi , Miklos Szeredi , , linux-kernel , linux-fsdevel Message-Id: <20190612170259.GA27637@deco.navytux.spb.ru> References: <876aefd0-808a-bb4b-0897-191f0a8d9e12@eikelenboom.it> <20190611202738.GA22556@deco.navytux.spb.ru> <20190612112544.GA21465@deco.navytux.spb.ru> <20190612141220.GA25389@deco.navytux.spb.ru> In-Reply-To: X-Report-Abuse: Please forward a copy of this message, including all headers, to abuse@mandrill.com X-Report-Abuse: You can also report abuse here: http://mandrillapp.com/contact/abuse?id=31050260.145d451a13654eaaa66dd24b26a9f854 X-Mandrill-User: md_31050260 Date: Wed, 12 Jun 2019 17:03:05 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 12, 2019 at 06:28:17PM +0200, Sander Eikelenboom wrote: > On 12/06/2019 16:12, Kirill Smelkov wrote: > > On Wed, Jun 12, 2019 at 03:03:49PM +0200, Sander Eikelenboom wrote: > >> On 12/06/2019 13:25, Kirill Smelkov wrote: > >>> On Wed, Jun 12, 2019 at 09:44:49AM +0200, Miklos Szeredi wrote: > >>>> On Tue, Jun 11, 2019 at 10:28 PM Kirill Smelkov wr= ote: > >>>> > >>>>> Miklos, would 4K -> `sizeof(fuse_in_header) + sizeof(fuse_write_in)= ` for > >>>>> header room change be accepted? > >>>> > >>>> Yes, next cycle. For 4.2 I'll just push the revert. > >>> > >>> Thanks Miklos. Please consider queuing the following patch for 5.3. > >>> Sander, could you please confirm that glusterfs is not broken with th= is > >>> version of the check? > >>> > >>> Thanks beforehand, > >>> Kirill > >> > >> > >> Hmm unfortunately it doesn't build, see below. > >> [...] > >> fs/fuse/dev.c:1336:14: error: =E2=80=98fuse_in_header=E2=80=99 undecla= red (first use in this function) > >> sizeof(fuse_in_header) + sizeof(fuse_write_in) + fc->max_write)= ) > > > > Sorry, my bad, it was missing "struct" before fuse_in_header. I > > originally compile-tested the patch with `make -j4`, was distracted ont= o > > other topic and did not see the error after returning due to long tail > > of successful CC lines. Apologize for the inconvenience. Below is a > > fixed patch that was both compile-tested and runtime-tested with my FUS= E > > workloads (non-glusterfs). > > > > Kirill > > > > Just tested and it works for me, thanks ! Thanks for feedback. Kirill