From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2F42C31E47 for ; Wed, 12 Jun 2019 17:10:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BCB0F2177E for ; Wed, 12 Jun 2019 17:10:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391799AbfFLRK4 (ORCPT ); Wed, 12 Jun 2019 13:10:56 -0400 Received: from mga11.intel.com ([192.55.52.93]:44951 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391554AbfFLRKz (ORCPT ); Wed, 12 Jun 2019 13:10:55 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jun 2019 10:10:54 -0700 X-ExtLoop1: 1 Received: from skuppusw-desk.jf.intel.com ([10.54.74.33]) by fmsmga008.fm.intel.com with ESMTP; 12 Jun 2019 10:10:54 -0700 From: sathyanarayanan.kuppuswamy@linux.intel.com To: bhelgaas@google.com Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, ashok.raj@intel.com, keith.busch@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, mike.campin@intel.com Subject: [PATCH v2 1/1] PCI/IOV: Fix incorrect cfg_size for VF > 0 Date: Wed, 12 Jun 2019 10:06:47 -0700 Message-Id: <20190612170647.43220-1-sathyanarayanan.kuppuswamy@linux.intel.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kuppuswamy Sathyanarayanan Commit 975bb8b4dc93 ("PCI/IOV: Use VF0 cached config space size for other VFs") calculates and caches the cfg_size for VF0 device before initializing the pcie_cap of the device which results in using incorrect cfg_size for all VF devices > 0. So set pcie_cap of the device before calculating the cfg_size of VF0 device. Fixes: 975bb8b4dc93 ("PCI/IOV: Use VF0 cached config space size for other VFs") Cc: Ashok Raj Suggested-by: Mike Campin Signed-off-by: Kuppuswamy Sathyanarayanan --- Changes since v1: * Fixed a typo in commit message. drivers/pci/iov.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c index 3aa115ed3a65..2869011c0e35 100644 --- a/drivers/pci/iov.c +++ b/drivers/pci/iov.c @@ -160,6 +160,7 @@ int pci_iov_add_virtfn(struct pci_dev *dev, int id) virtfn->device = iov->vf_device; virtfn->is_virtfn = 1; virtfn->physfn = pci_dev_get(dev); + virtfn->pcie_cap = pci_find_capability(virtfn, PCI_CAP_ID_EXP); if (id == 0) pci_read_vf_config_common(virtfn); -- 2.21.0