From: Daniel Vetter <daniel@ffwll.ch>
To: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Cc: "Alex Deucher" <alexdeucher@gmail.com>,
"Harry Wentland" <harry.wentland@amd.com>,
"Leo Li" <sunpeng.li@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David (ChunMing) Zhou" <David1.Zhou@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Dmytro Laktyushkin" <Dmytro.Laktyushkin@amd.com>,
"Bhawanpreet Lakha" <Bhawanpreet.Lakha@amd.com>,
"Tony Cheng" <tony.cheng@amd.com>,
"Anthony Koo" <Anthony.Koo@amd.com>,
"Charlene Liu" <charlene.liu@amd.com>,
"Nicholas Kazlauskas" <nicholas.kazlauskas@amd.com>,
"Yongqiang Sun" <yongqiang.sun@amd.com>,
"Gloria Li" <geling.li@amd.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/amd/display: fix compilation error
Date: Thu, 13 Jun 2019 10:23:46 +0200 [thread overview]
Message-ID: <20190613082346.GH23020@phenom.ffwll.local> (raw)
In-Reply-To: <20190613024854.GA25104@hari-Inspiron-1545>
On Thu, Jun 13, 2019 at 08:18:54AM +0530, Hariprasad Kelam wrote:
> On Wed, Jun 12, 2019 at 10:35:26PM -0400, Alex Deucher wrote:
> > On Wed, Jun 12, 2019 at 10:34 PM Hariprasad Kelam
> > <hariprasad.kelam@gmail.com> wrote:
> > >
> > > this patch fixes below compilation error
> > >
> > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In
> > > function ‘dcn10_apply_ctx_for_surface’:
> > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2378:3:
> > > error: implicit declaration of function ‘udelay’
> > > [-Werror=implicit-function-declaration]
> > > udelay(underflow_check_delay_us);
> > >
> > > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
> >
> > What branch is this patch based on?
> >
> > Alex
>
> Hi Alex,
>
> It is on linux-next
drm-misc-next has Sam's header cleanup. I guess we pull linux/delay.h in
implicitly somewhere, but not for all configs.
-Daniel
>
> Thanks,
> Hariprasad k
> > > ---
> > > drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> > > index d2352949..1ac9a4f 100644
> > > --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> > > +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> > > @@ -23,6 +23,7 @@
> > > *
> > > */
> > >
> > > +#include <linux/delay.h>
> > > #include "dm_services.h"
> > > #include "core_types.h"
> > > #include "resource.h"
> > > --
> > > 2.7.4
> > >
> > > _______________________________________________
> > > amd-gfx mailing list
> > > amd-gfx@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2019-06-13 16:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 2:32 Hariprasad Kelam
2019-06-13 2:35 ` Alex Deucher
2019-06-13 2:48 ` Hariprasad Kelam
2019-06-13 8:23 ` Daniel Vetter [this message]
2019-06-13 18:42 ` Sam Ravnborg
2019-06-13 18:52 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190613082346.GH23020@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=Anthony.Koo@amd.com \
--cc=Bhawanpreet.Lakha@amd.com \
--cc=David1.Zhou@amd.com \
--cc=Dmytro.Laktyushkin@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=alexdeucher@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=charlene.liu@amd.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=geling.li@amd.com \
--cc=hariprasad.kelam@gmail.com \
--cc=harry.wentland@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicholas.kazlauskas@amd.com \
--cc=sunpeng.li@amd.com \
--cc=tony.cheng@amd.com \
--cc=yongqiang.sun@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®