From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A32E8C31E45 for ; Thu, 13 Jun 2019 15:54:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 850C720851 for ; Thu, 13 Jun 2019 15:54:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390169AbfFMPyx (ORCPT ); Thu, 13 Jun 2019 11:54:53 -0400 Received: from sauhun.de ([88.99.104.3]:41922 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390076AbfFMPy0 (ORCPT ); Thu, 13 Jun 2019 11:54:26 -0400 Received: from localhost (p5486CF99.dip0.t-ipconnect.de [84.134.207.153]) by pokefinder.org (Postfix) with ESMTPSA id 4BA5D4A1290; Thu, 13 Jun 2019 17:54:24 +0200 (CEST) From: Wolfram Sang To: linux-media@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, Wolfram Sang , Antti Palosaari , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org Subject: [PATCH 1/4] media: cxd2820r: don't check retval after our own assignemt Date: Thu, 13 Jun 2019 17:54:17 +0200 Message-Id: <20190613155421.16408-2-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190613155421.16408-1-wsa+renesas@sang-engineering.com> References: <20190613155421.16408-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org No need to check a retval after we assigned a constant to it. Signed-off-by: Wolfram Sang --- drivers/media/dvb-frontends/cxd2820r_core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/dvb-frontends/cxd2820r_core.c b/drivers/media/dvb-frontends/cxd2820r_core.c index 1f006f8e8cc2..99a186ddddb2 100644 --- a/drivers/media/dvb-frontends/cxd2820r_core.c +++ b/drivers/media/dvb-frontends/cxd2820r_core.c @@ -636,8 +636,7 @@ static int cxd2820r_probe(struct i2c_client *client, if (!priv->client[1]) { ret = -ENODEV; dev_err(&client->dev, "I2C registration failed\n"); - if (ret) - goto err_regmap_0_regmap_exit; + goto err_regmap_0_regmap_exit; } priv->regmap[1] = regmap_init_i2c(priv->client[1], ®map_config1); -- 2.20.1