From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22E8CC31E45 for ; Thu, 13 Jun 2019 18:24:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E27E620679 for ; Thu, 13 Jun 2019 18:24:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="bFuTpY0d" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727242AbfFMSYK (ORCPT ); Thu, 13 Jun 2019 14:24:10 -0400 Received: from mail-oi1-f201.google.com ([209.85.167.201]:55161 "EHLO mail-oi1-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725889AbfFMSYK (ORCPT ); Thu, 13 Jun 2019 14:24:10 -0400 Received: by mail-oi1-f201.google.com with SMTP id w123so2299621oie.21 for ; Thu, 13 Jun 2019 11:24:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=SGwIsVM07EtaffbmDpnZVkUL5vQqSHg2GIU9vXpPeb8=; b=bFuTpY0dyBqE8maBPH0hVPPVcI6tJeD7mTXq09nzb0xfgTnClr2nbCxQSh3PO20I2c fwWsMc7xvaUqCqUXeHpBzL935+Q3B7XTWpsNdg0TLgGEXeqJonqaAGZH1WO+3KQdWr9W PxFw8FCSiZdoNLsPSqFQIGXkjVc11F+oeEfT2y2U68FxvtyxpxhCP/UoKagERz8dVLM0 LNhSOp9MQy979IxebyJ7oiu1tIiFXO9SuZFHpIXWFoNtZXQQduUwcgbkwi6HaV0KrSrV shXQCuCddSEyWg0MleMi0nNm9hNvu+ykz1VEp6VOkJMIFXCKz/3H6j7D4Qx2xXjSdLrm LGaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=SGwIsVM07EtaffbmDpnZVkUL5vQqSHg2GIU9vXpPeb8=; b=QZketLpXPi6mAVlb0+WwvJP+xV7hcmcRgMWKt7MYcq9Fq/QWTp9LCyAN4kCCmCQXMU tw+y2Hcx8QyNwDBVTodphWgOw53IvPfdgLYoS6Rjet7Q4h+tg6dgmUOYHmFwoKDKC9U5 scQFvT0JhazTqdOxVd/mucPemvyrJD5Hooy62dwiBwhDqeekdCeKfPcwR2BAqq7XIpih MVHb7OzqKfaE6oouNVhYGnZ9HZKGdYR3jpoRZ4x4JzizGd/RjsPlrIXwT4uBkb0TfHfJ jIYrm+r9+DJ1yk+//DR3ZTPmapi26Xq3c8lGYxrbQTdU7OAnkYzpVPlNHX1rTxIY9JkY v8Ng== X-Gm-Message-State: APjAAAUpQuNfYHjyfBSOQWJgif8yuTU5WHUsH4/oxUYPLzhqTOyMIpuC I5MCMn00ts1cSpfF7Fa91LpBzz1Awg== X-Google-Smtp-Source: APXvYqwksvyhmI8WeWO3LbQ+qZI+KVFYpKjUb5OERlzv7A+ohpJ+NsjsBGcXCiVq45OeC0V2fdwTGVOYRg== X-Received: by 2002:aca:50c6:: with SMTP id e189mr3771958oib.63.1560450249360; Thu, 13 Jun 2019 11:24:09 -0700 (PDT) Date: Thu, 13 Jun 2019 11:23:26 -0700 In-Reply-To: Message-Id: <20190613182326.237391-1-nhuck@google.com> Mime-Version: 1.0 References: X-Mailer: git-send-email 2.22.0.rc2.383.gf4fbbf30c2-goog Subject: [PATCH v2] Input: atmel_mxt_ts - fix -Wunused-const-variable From: Nathan Huckleberry To: nick@shmanahar.org, dmitry.torokhov@gmail.com Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Nathan Huckleberry , clang-built-linux@googlegroups.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Clang produces the following warning drivers/input/touchscreen/atmel_mxt_ts.c:259:42: warning: unused variable 'mxt_video_fops' [-Wunused-const-variable] static const struct v4l2_file_operations mxt_video_fops = { Since mxt_video_fops is only used inside an ifdef. It should be moved inside the ifdef. Cc: clang-built-linux@googlegroups.com Link: https://github.com/ClangBuiltLinux/linux/issues/527 Signed-off-by: Nathan Huckleberry --- Changes from v1 -> v2 * Moved definition of mxt_video_fops into existing ifdef drivers/input/touchscreen/atmel_mxt_ts.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c index 19378f200c63..0dae381c6637 100644 --- a/drivers/input/touchscreen/atmel_mxt_ts.c +++ b/drivers/input/touchscreen/atmel_mxt_ts.c @@ -256,16 +256,6 @@ enum v4l_dbg_inputs { MXT_V4L_INPUT_MAX, }; -static const struct v4l2_file_operations mxt_video_fops = { - .owner = THIS_MODULE, - .open = v4l2_fh_open, - .release = vb2_fop_release, - .unlocked_ioctl = video_ioctl2, - .read = vb2_fop_read, - .mmap = vb2_fop_mmap, - .poll = vb2_fop_poll, -}; - enum mxt_suspend_mode { MXT_SUSPEND_DEEP_SLEEP = 0, MXT_SUSPEND_T9_CTRL = 1, @@ -2218,6 +2208,16 @@ static int mxt_init_t7_power_cfg(struct mxt_data *data) } #ifdef CONFIG_TOUCHSCREEN_ATMEL_MXT_T37 +static const struct v4l2_file_operations mxt_video_fops = { + .owner = THIS_MODULE, + .open = v4l2_fh_open, + .release = vb2_fop_release, + .unlocked_ioctl = video_ioctl2, + .read = vb2_fop_read, + .mmap = vb2_fop_mmap, + .poll = vb2_fop_poll, +}; + static u16 mxt_get_debug_value(struct mxt_data *data, unsigned int x, unsigned int y) { -- 2.22.0.rc2.383.gf4fbbf30c2-goog