From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3B6EC31E45 for ; Thu, 13 Jun 2019 18:34:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 970DA2133D for ; Thu, 13 Jun 2019 18:34:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728323AbfFMSeL (ORCPT ); Thu, 13 Jun 2019 14:34:11 -0400 Received: from mga09.intel.com ([134.134.136.24]:21227 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727378AbfFMSeJ (ORCPT ); Thu, 13 Jun 2019 14:34:09 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jun 2019 11:34:08 -0700 X-ExtLoop1: 1 Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.157]) by fmsmga001.fm.intel.com with SMTP; 13 Jun 2019 11:34:05 -0700 Received: by lahna (sSMTP sendmail emulation); Thu, 13 Jun 2019 21:34:05 +0300 Date: Thu, 13 Jun 2019 21:34:05 +0300 From: Mika Westerberg To: Stefan Roese Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Yegor Yefremov , Andy Shevchenko , Giulio Benetti , Greg Kroah-Hartman Subject: Re: [PATCH 3/3 v6] tty/serial/8250: use mctrl_gpio helpers Message-ID: <20190613183405.GT2640@lahna.fi.intel.com> References: <20190613154542.32438-1-sr@denx.de> <20190613154542.32438-3-sr@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190613154542.32438-3-sr@denx.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 13, 2019 at 05:45:42PM +0200, Stefan Roese wrote: > From: Yegor Yefremov > > This patch permits the usage for GPIOs to control > the CTS/RTS/DTR/DSR/DCD/RI signals. > > Changed by Stefan: > Only call mctrl_gpio_init(), if the device has no ACPI companion device > to not break existing ACPI based systems. Also only use the mctrl_gpio_ > functions when "gpios" is available. > > Use MSR / MCR <-> TIOCM wrapper functions. > > Signed-off-by: Yegor Yefremov > Signed-off-by: Greg Kroah-Hartman > Signed-off-by: Stefan Roese > Cc: Mika Westerberg Reviewed-by: Mika Westerberg