From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 709EAC31E44 for ; Fri, 14 Jun 2019 09:57:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4F664208CA for ; Fri, 14 Jun 2019 09:57:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727238AbfFNJ5A (ORCPT ); Fri, 14 Jun 2019 05:57:00 -0400 Received: from mga07.intel.com ([134.134.136.100]:18229 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725812AbfFNJ47 (ORCPT ); Fri, 14 Jun 2019 05:56:59 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jun 2019 02:56:58 -0700 X-ExtLoop1: 1 Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.157]) by fmsmga001.fm.intel.com with SMTP; 14 Jun 2019 02:56:56 -0700 Received: by lahna (sSMTP sendmail emulation); Fri, 14 Jun 2019 12:56:55 +0300 Date: Fri, 14 Jun 2019 12:56:55 +0300 From: Mika Westerberg To: linux-kernel@vger.kernel.org Cc: Andreas Noever , Michael Jamet , Yehezkel Bernat , Lukas Wunner , Peter Bowen Subject: Re: [PATCH] thunderbolt: Implement CIO reset correctly for Titan Ridge Message-ID: <20190614095655.GB2640@lahna.fi.intel.com> References: <20190607111451.59648-1-mika.westerberg@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190607111451.59648-1-mika.westerberg@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 07, 2019 at 02:14:51PM +0300, Mika Westerberg wrote: > When starting ICM firmware on Apple systems we need to perform CIO reset > as part of the flow. However, it turns out that the reset register has > changed to another location in Titan Ridge. > > Fix this by introducing ->cio_reset() callback with corresponding > implementations for Alpine and Titan Ridge. > > Fixes: 4630d6ae6e3 ("thunderbolt: Start firmware on Titan Ridge Apple systems") > Reported-by: Peter Bowen > Signed-off-by: Mika Westerberg Applied to thunderbolt.git/fixes.