From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D3E5C31E4C for ; Fri, 14 Jun 2019 11:10:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6FFC82133D for ; Fri, 14 Jun 2019 11:10:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727427AbfFNLKz (ORCPT ); Fri, 14 Jun 2019 07:10:55 -0400 Received: from latin.grep.be ([46.4.76.168]:42671 "EHLO latin.grep.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727262AbfFNLKy (ORCPT ); Fri, 14 Jun 2019 07:10:54 -0400 X-Greylist: delayed 2218 seconds by postgrey-1.27 at vger.kernel.org; Fri, 14 Jun 2019 07:10:53 EDT Received: from [105.227.108.147] (helo=gangtai.home.grep.be) by latin.grep.be with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hbjWp-0000YE-NR; Fri, 14 Jun 2019 12:33:52 +0200 Received: from wouter by gangtai.home.grep.be with local (Exim 4.92) (envelope-from ) id 1hbjWh-0003hH-Vl; Fri, 14 Jun 2019 12:33:43 +0200 Date: Fri, 14 Jun 2019 12:33:43 +0200 From: Wouter Verhelst To: Josef Bacik Cc: Roman Stratiienko , linux-kernel@vger.kernel.org, nbd@other.debian.org, Aleksandr Bulyshchenko , linux-block@vger.kernel.org, axboe@kernel.dkn.org Subject: Re: [PATCH 2/2] nbd: add support for nbd as root device Message-ID: <20190614103343.GB11340@grep.be> References: <20190612163144.18486-1-roman.stratiienko@globallogic.com> <20190612163144.18486-2-roman.stratiienko@globallogic.com> <20190613135241.aghcrrz7rg2au3bw@MacBook-Pro-91.local> <20190613145535.tdesq3y2xy6ycpw7@MacBook-Pro-91.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190613145535.tdesq3y2xy6ycpw7@MacBook-Pro-91.local> X-Speed: Gates' Law: Every 18 months, the speed of software halves. Organization: none User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 13, 2019 at 10:55:36AM -0400, Josef Bacik wrote: > Also I mean that there are a bunch of different nbd servers out there. We have > our own here at Facebook, qemu has one, IIRC there's a ceph one. I can't claim to know about the Facebook one of course, but the qemu one uses the same handshake protocol as anyone else. The ceph ones that I've seen do too (but there are various implementations of that, so...). > They all have their own connection protocols. The beauty of NBD is > that it doesn't have to know about that part, it just does the block > device part, and I'd really rather leave it that way. Thanks, Sure. OTOH, there is definitely also a benefit to using the same handshake protocol everywhere, for interoperability reasons. -- To the thief who stole my anti-depressants: I hope you're happy -- seen somewhere on the Internet on a photo of a billboard