From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92343C31E4B for ; Fri, 14 Jun 2019 15:02:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6544321721 for ; Fri, 14 Jun 2019 15:02:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="KF4oP5QO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725993AbfFNPCY (ORCPT ); Fri, 14 Jun 2019 11:02:24 -0400 Received: from mail.skyhub.de ([5.9.137.197]:52784 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725823AbfFNPCY (ORCPT ); Fri, 14 Jun 2019 11:02:24 -0400 Received: from zn.tnic (p200300EC2F097F0010F3CEDA9C41B474.dip0.t-ipconnect.de [IPv6:2003:ec:2f09:7f00:10f3:ceda:9c41:b474]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 3F7C11EC0ABC; Fri, 14 Jun 2019 17:02:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1560524543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=wVbIeB5RBruw3P5Jvb8KpfKPlB6Et64szvPsVG3HZRA=; b=KF4oP5QOFoHCC2JFIpgWbi89njsovgHX7BR9g/ALuWBRKX46SEeBOoxFhIHlTO3bp0OD17 EIY9/scSU8rNkht9a7JYSthuY/3qNI9XYO6Y6ABDKJWbFSB99MsZnRlJk08cV/02/qOgct AnM9hK5lSwukJwZWEzeSkhnb3m/Eu6U= Date: Fri, 14 Jun 2019 17:02:19 +0200 From: Borislav Petkov To: Fenghua Yu Cc: Sean Christopherson , Thomas Gleixner , Ingo Molnar , H Peter Anvin , Ravi V Shankar , linux-kernel , x86 , Radim =?utf-8?B?S3LEjW3DocWZ?= , Paolo Bonzini Subject: Re: [RFC PATCH 2/3] x86/cpufeatures: Combine word 11 and 12 into new scattered features word 11 Message-ID: <20190614150219.GK2586@zn.tnic> References: <1560459064-195037-1-git-send-email-fenghua.yu@intel.com> <1560459064-195037-3-git-send-email-fenghua.yu@intel.com> <20190614114410.GD2586@zn.tnic> <20190614122749.GE2586@zn.tnic> <20190614131701.GA198207@romley-ivt3.sc.intel.com> <20190614134123.GF2586@zn.tnic> <20190614141424.GA12191@linux.intel.com> <20190614141519.GC198207@romley-ivt3.sc.intel.com> <20190614142611.GI2586@zn.tnic> <20190614142550.GD198207@romley-ivt3.sc.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190614142550.GD198207@romley-ivt3.sc.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 14, 2019 at 07:25:51AM -0700, Fenghua Yu wrote: > But without this small patch, CPUID_7_EDX is 17 instead of > NCAPINTS(19)-1=18 in patch 0002. Of course CPUID_7_EDX is 18 correctly > evetually after applying patch 0003 which add the word 12 back. Ok, then I guess the easiest should be if not remove defines from cpuid_leafs but rename them, no? -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.