From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ACA7C31E4B for ; Fri, 14 Jun 2019 20:35:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 49C372084D for ; Fri, 14 Jun 2019 20:35:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560544529; bh=qSVzhz4JaUwIXUhwr10K4KcEBohGrcpzgC1WZjaRHbQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Z3crRp3Y3fW3uSYgYPtjkNJ8iT2a5ejveKQpdDYtTetPHxdx5ktjPfMRBRrz1ROm8 HZTRjO2PoWW3FVqK1c1L8MjAb/c2rajWkoII0aYrRZSp6XEICmmpLXMGLHahuI/ifj jgtGdAxpTKCKef3dx+3t/ooMBTqiuyxKJhe6/yyY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728152AbfFNUf1 (ORCPT ); Fri, 14 Jun 2019 16:35:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:52374 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727254AbfFNU34 (ORCPT ); Fri, 14 Jun 2019 16:29:56 -0400 Received: from sasha-vm.mshome.net (unknown [131.107.159.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 882BF21841; Fri, 14 Jun 2019 20:29:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560544195; bh=qSVzhz4JaUwIXUhwr10K4KcEBohGrcpzgC1WZjaRHbQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BdBHDf6UXchpxtXsh9ZZb4A92UZB/GHL+8o5uTjZdjegutzPUR8Nrkhd0VLtDxom4 OicMi0pxjrQMAmnZZTICQhgcJg6YgYjtXrcERloB1pgV1QpWV5Va0osnS58VcMtpJK k6EOYRGp58GF/bkqAeQVhtyZT/n3ZElZ6rO3bPzU= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Kamenee Arumugam , "Michael J . Ruhl" , Dennis Dalessandro , Jason Gunthorpe , Sasha Levin , linux-rdma@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 14/39] IB/hfi1: Validate page aligned for a given virtual address Date: Fri, 14 Jun 2019 16:29:19 -0400 Message-Id: <20190614202946.27385-14-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190614202946.27385-1-sashal@kernel.org> References: <20190614202946.27385-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kamenee Arumugam [ Upstream commit 97736f36dbebf2cda2799db3b54717ba5b388255 ] User applications can register memory regions for TID buffers that are not aligned on page boundaries. Hfi1 is expected to pin those pages in memory and cache the pages with mmu_rb. The rb tree will fail to insert pages that are not aligned correctly. Validate whether a given virtual address is page aligned before pinning. Fixes: 7e7a436ecb6e ("staging/hfi1: Add TID entry program function body") Reviewed-by: Michael J. Ruhl Signed-off-by: Kamenee Arumugam Signed-off-by: Dennis Dalessandro Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/hw/hfi1/user_exp_rcv.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/infiniband/hw/hfi1/user_exp_rcv.c b/drivers/infiniband/hw/hfi1/user_exp_rcv.c index dbe7d14a5c76..4e986ca4dd35 100644 --- a/drivers/infiniband/hw/hfi1/user_exp_rcv.c +++ b/drivers/infiniband/hw/hfi1/user_exp_rcv.c @@ -324,6 +324,9 @@ int hfi1_user_exp_rcv_setup(struct hfi1_filedata *fd, u32 *tidlist = NULL; struct tid_user_buf *tidbuf; + if (!PAGE_ALIGNED(tinfo->vaddr)) + return -EINVAL; + tidbuf = kzalloc(sizeof(*tidbuf), GFP_KERNEL); if (!tidbuf) return -ENOMEM; -- 2.20.1