From: Nick Crews <ncrews@chromium.org>
To: enric.balletbo@collabora.com, bleung@chromium.org
Cc: linux-kernel@vger.kernel.org, dlaurie@chromium.org,
djkurtz@chromium.org, dtor@google.com, sjg@chromium.org,
kernel-janitors@vger.kernel.org, dan.carpenter@oracle.com,
Nick Crews <ncrews@chromium.org>
Subject: [PATCH 1/2] platform/chrome: wilco_ec: Fix unreleased lock in event_read()
Date: Fri, 14 Jun 2019 14:56:31 -0600 [thread overview]
Message-ID: <20190614205631.90222-1-ncrews@chromium.org> (raw)
When copying an event to userspace failed, the event queue
lock was never released. This fixes that.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Nick Crews <ncrews@chromium.org>
---
drivers/platform/chrome/wilco_ec/event.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/chrome/wilco_ec/event.c b/drivers/platform/chrome/wilco_ec/event.c
index 4d2776f77dbd..1eed55681598 100644
--- a/drivers/platform/chrome/wilco_ec/event.c
+++ b/drivers/platform/chrome/wilco_ec/event.c
@@ -342,7 +342,7 @@ static ssize_t event_read(struct file *filp, char __user *buf, size_t count,
struct ec_event_entry, list);
n_bytes_written = entry->size;
if (copy_to_user(buf, &entry->event, n_bytes_written))
- return -EFAULT;
+ n_bytes_written = -EFAULT;
list_del(&entry->list);
kfree(entry);
dev_data->num_events--;
--
2.20.1
next reply other threads:[~2019-06-14 20:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 20:56 Nick Crews [this message]
2019-06-14 20:56 ` [PATCH 2/2] platform/chrome: wilco_ec: Add circular buffer as event queue Nick Crews
2019-06-18 8:40 ` Enric Balletbo i Serra
2019-06-18 8:38 ` [PATCH 1/2] platform/chrome: wilco_ec: Fix unreleased lock in event_read() Enric Balletbo i Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614205631.90222-1-ncrews@chromium.org \
--to=ncrews@chromium.org \
--cc=bleung@chromium.org \
--cc=dan.carpenter@oracle.com \
--cc=djkurtz@chromium.org \
--cc=dlaurie@chromium.org \
--cc=dtor@google.com \
--cc=enric.balletbo@collabora.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sjg@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®