From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2038CC31E50 for ; Mon, 17 Jun 2019 13:42:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F070A2084B for ; Mon, 17 Jun 2019 13:42:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727078AbfFQNmr (ORCPT ); Mon, 17 Jun 2019 09:42:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:32912 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725884AbfFQNmr (ORCPT ); Mon, 17 Jun 2019 09:42:47 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F3FC120657; Mon, 17 Jun 2019 13:42:45 +0000 (UTC) Date: Mon, 17 Jun 2019 09:42:44 -0400 From: Steven Rostedt To: Colin King Cc: Ingo Molnar , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tracing: remove redundant assignment to pointer 'event' Message-ID: <20190617094244.14562920@gandalf.local.home> In-Reply-To: <20190617123722.27376-1-colin.king@canonical.com> References: <20190617123722.27376-1-colin.king@canonical.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 17 Jun 2019 13:37:22 +0100 Colin King wrote: > From: Colin Ian King > > The value assigned to pointer 'event' is never read and hence it > is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > --- > kernel/trace/trace_events_hist.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c > index ca6b0dff60c5..0013b43d8b4d 100644 > --- a/kernel/trace/trace_events_hist.c > +++ b/kernel/trace/trace_events_hist.c > @@ -1294,7 +1294,6 @@ static int __create_synth_event(int argc, const char *name, const char **argv) > event = alloc_synth_event(name, n_fields, fields); > if (IS_ERR(event)) { > ret = PTR_ERR(event); > - event = NULL; This is one of those cases where I rather not touch it. Yeah, it may not be read, but assigning event to NULL isn't dangerous here. And if we change the code to expect event to be NULL or something real, it is better to keep this. -- Steve > goto err; > } > ret = register_synth_event(event);