From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27893C31E57 for ; Mon, 17 Jun 2019 13:15:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DCBB82085A for ; Mon, 17 Jun 2019 13:15:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Xt2zW3Cs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728044AbfFQNPW (ORCPT ); Mon, 17 Jun 2019 09:15:22 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:37124 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725884AbfFQNPW (ORCPT ); Mon, 17 Jun 2019 09:15:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=g2RSyr1LswKR5yVaExwwUghHr8GGOtj1VRSVsfBu1GQ=; b=Xt2zW3CsTdU+5dL1qgV7m+ZXj 9YyYU2Wk6Tm8jGRvrjoLS1or4I9L8Nqw0mQ0LRGN+KocsYE/05sPoA1/cTAa3zfdt8zIsocYAYBlg FgUkxfwPxd0lS5E5WSJY35W31PExqnu6CzwadtRyYO9xC9msAFx2RSs+tbpZQ6XgdZAH0kfP2ulXj nOcKt7dpG5G3pI6AqfqWoqte8gIMa4B6F0bH8LWDBzSBZ4CjeVlm38WCclwKZBMGauNqijnSWoqIs Lpk4LxEgpQUm/LviWC5Z98ShD4yCngQetj2o1PDPpTuhHsae5J9s4IXxMJyukLQ+kdkej905zEcu5 MC33MfY3g==; Received: from hch by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1hcrTP-00014F-MJ; Mon, 17 Jun 2019 13:14:59 +0000 Date: Mon, 17 Jun 2019 06:14:59 -0700 From: 'Christoph Hellwig' To: Alastair D'Silva Cc: 'Christoph Hellwig' , 'Peter Zijlstra' , 'Andrew Morton' , 'David Hildenbrand' , 'Oscar Salvador' , 'Michal Hocko' , 'Pavel Tatashin' , 'Wei Yang' , 'Arun KS' , 'Qian Cai' , 'Thomas Gleixner' , 'Ingo Molnar' , 'Josh Poimboeuf' , 'Jiri Kosina' , 'Mukesh Ojha' , 'Mike Rapoport' , 'Baoquan He' , 'Logan Gunthorpe' , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org Subject: Re: [PATCH 5/5] mm/hotplug: export try_online_node Message-ID: <20190617131459.GA639@infradead.org> References: <20190617043635.13201-1-alastair@au1.ibm.com> <20190617043635.13201-6-alastair@au1.ibm.com> <20190617065921.GV3436@hirez.programming.kicks-ass.net> <20190617071527.GA14003@infradead.org> <068d01d524e2$aa6f3000$ff4d9000$@d-silva.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <068d01d524e2$aa6f3000$ff4d9000$@d-silva.org> User-Agent: Mutt/1.11.4 (2019-03-13) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 17, 2019 at 06:00:00PM +1000, Alastair D'Silva wrote: > > And all that should go through our pmem APIs, not not directly poke into > mm > > internals. And if you still need core patches send them along with the > actual > > driver. > > I tried that, but I was getting crashes as the NUMA data structures for that > node were not initialised. > > Calling this was required to prevent uninitialized accesses in the pmem > library. Please send your driver to the linux-nvdimm and linux-mm lists so that it can be carefully reviewed.