From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58BBAC31E5B for ; Mon, 17 Jun 2019 15:45:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2E3DB2084A for ; Mon, 17 Jun 2019 15:45:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="tGZ39Zzu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728402AbfFQPpH (ORCPT ); Mon, 17 Jun 2019 11:45:07 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:49498 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726292AbfFQPpH (ORCPT ); Mon, 17 Jun 2019 11:45:07 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id x5HFipSq091402; Mon, 17 Jun 2019 10:44:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1560786291; bh=McgqI3mDBBahPgI7AYaJFbF+RYWPhclsx1BVQphtdss=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=tGZ39ZzusXUIC2LOEMo6l1t/H/cuu47XY3JhCagVn/SHGDqiskMsCG/5aLqGs7Oz/ AoaFtY8aYXKKz3N0lwp+wIcg25wa9QMRSJ52Y2Q8hgMj3PODs25N+uxhClXaZeqxG1 EvKShXPUzIyfITQapeWr2zzAHRQOLZEqszxdkqwE= Received: from DFLE103.ent.ti.com (dfle103.ent.ti.com [10.64.6.24]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x5HFipq0126827 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 17 Jun 2019 10:44:51 -0500 Received: from DFLE114.ent.ti.com (10.64.6.35) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Mon, 17 Jun 2019 10:44:50 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Mon, 17 Jun 2019 10:44:50 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id x5HFio7i120698; Mon, 17 Jun 2019 10:44:50 -0500 Date: Mon, 17 Jun 2019 10:43:42 -0500 From: Nishanth Menon To: Arnd Bergmann CC: Santosh Shilimkar , Lokesh Vutla , Marc Zyngier , Olof Johansson , Tony Lindgren , , Subject: Re: [PATCH] soc: ti: fix irq-ti-sci link error Message-ID: <20190617154342.n2tre474cfyvraw3@kahuna> References: <20190617130149.1782930-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20190617130149.1782930-1-arnd@arndb.de> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15:01-20190617, Arnd Bergmann wrote: > The irqchip driver depends on the SoC specific driver, but we want > to be able to compile-test it elsewhere: > > WARNING: unmet direct dependencies detected for TI_SCI_INTA_MSI_DOMAIN > Depends on [n]: SOC_TI [=n] > Selected by [y]: > - TI_SCI_INTA_IRQCHIP [=y] && TI_SCI_PROTOCOL [=y] > > drivers/irqchip/irq-ti-sci-inta.o: In function `ti_sci_inta_irq_domain_probe': > irq-ti-sci-inta.c:(.text+0x204): undefined reference to `ti_sci_inta_msi_create_irq_domain' > > Rearrange the Kconfig and Makefile so we build the soc driver whenever > its users are there, regardless of the SOC_TI option. > > Fixes: 49b323157bf1 ("soc: ti: Add MSI domain bus support for Interrupt Aggregator") > Fixes: f011df6179bd ("irqchip/ti-sci-inta: Add msi domain support") > Signed-off-by: Arnd Bergmann > --- > drivers/soc/Makefile | 2 +- > drivers/soc/ti/Kconfig | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile > index 524ecdc2a9bb..2ec355003524 100644 > --- a/drivers/soc/Makefile > +++ b/drivers/soc/Makefile > @@ -22,7 +22,7 @@ obj-$(CONFIG_ARCH_ROCKCHIP) += rockchip/ > obj-$(CONFIG_SOC_SAMSUNG) += samsung/ > obj-y += sunxi/ > obj-$(CONFIG_ARCH_TEGRA) += tegra/ > -obj-$(CONFIG_SOC_TI) += ti/ > +obj-y += ti/ > obj-$(CONFIG_ARCH_U8500) += ux500/ > obj-$(CONFIG_PLAT_VERSATILE) += versatile/ > obj-y += xilinx/ > diff --git a/drivers/soc/ti/Kconfig b/drivers/soc/ti/Kconfig > index ea0859f7b185..d7d50d48d05d 100644 > --- a/drivers/soc/ti/Kconfig > +++ b/drivers/soc/ti/Kconfig > @@ -75,10 +75,10 @@ config TI_SCI_PM_DOMAINS > called ti_sci_pm_domains. Note this is needed early in boot before > rootfs may be available. > > +endif # SOC_TI > + > config TI_SCI_INTA_MSI_DOMAIN > bool > select GENERIC_MSI_IRQ_DOMAIN > help > Driver to enable Interrupt Aggregator specific MSI Domain. > - > -endif # SOC_TI > -- > 2.20.0 > Looks fine to me. Lokesh? -- Regards, Nishanth Menon