From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DD79C31E5B for ; Mon, 17 Jun 2019 21:24:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 331C420861 for ; Mon, 17 Jun 2019 21:24:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560806653; bh=CRUyWK9NyptmT2V8ZmUnha77qJW0NiUSmcI4NGUdFCY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=IdL/9JymmCJ4LZqtK6AyRjFGjswNPDwxwtDUjczB1VmcAbTSUDN7RDJAjUrC7PeKi opV4rKZYY3JvvdIGUrnOZm/qq1qSalQdmb56fbIR0UFhGGWh0T9XBTwfW8FlHGvTDK ERwDnWP0KMbx9SJ4se0N/5mGSIkXx3KLMgPd4cl4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729871AbfFQVYL (ORCPT ); Mon, 17 Jun 2019 17:24:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:49634 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729215AbfFQVYK (ORCPT ); Mon, 17 Jun 2019 17:24:10 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DB8C820657; Mon, 17 Jun 2019 21:24:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560806649; bh=CRUyWK9NyptmT2V8ZmUnha77qJW0NiUSmcI4NGUdFCY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=f8Hq3N/X0Bl3XVFsgJJKvdtwv4LlvWBxADjIh/JUE1IwEBBrwL7t3PTjtSXl1M+fa 5165vjX2TpViKreE80HUaqG+y3OHQOjYW/OC8bF3kR9vy0eGqtV6+vHWK/FXjOb+Ot JR24QoNpJoO1rJmFLj1oVgeXlsPoQgAEThQcG7ek= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Takashi Sakamoto , Takashi Iwai Subject: [PATCH 4.19 10/75] ALSA: oxfw: allow PCM capture for Stanton SCS.1m Date: Mon, 17 Jun 2019 23:09:21 +0200 Message-Id: <20190617210753.265413601@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190617210752.799453599@linuxfoundation.org> References: <20190617210752.799453599@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Takashi Sakamoto commit d8fa87c368f5b4096c4746894fdcc195da285df1 upstream. Stanton SCS.1m can transfer isochronous packet with Multi Bit Linear Audio data channels, therefore it allows software to capture PCM substream. However, ALSA oxfw driver doesn't. This commit changes the driver to add one PCM substream for capture direction. Fixes: de5126cc3c0b ("ALSA: oxfw: add stream format quirk for SCS.1 models") Cc: # v4.5+ Signed-off-by: Takashi Sakamoto Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/firewire/oxfw/oxfw.c | 3 --- 1 file changed, 3 deletions(-) --- a/sound/firewire/oxfw/oxfw.c +++ b/sound/firewire/oxfw/oxfw.c @@ -170,9 +170,6 @@ static int detect_quirks(struct snd_oxfw oxfw->midi_input_ports = 0; oxfw->midi_output_ports = 0; - /* Output stream exists but no data channels are useful. */ - oxfw->has_output = false; - return snd_oxfw_scs1x_add(oxfw); }