Re: [PATCH] staging: rtl8723bs: os_dep: ioctl_linux: Make use rtw_zmalloc

[Hariprasad Kelam <hariprasad.kelam@gmail.com>]

On Sun, Jun 16, 2019 at 10:15:22AM +0300, Dan Carpenter wrote:
> On Sun, Jun 16, 2019 at 11:02:50AM +0530, Hariprasad Kelam wrote:
> > rtw_malloc with memset can be replace with rtw_zmalloc.
> > 
> > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
> > ---
> >  drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 12 +++---------
> >  1 file changed, 3 insertions(+), 9 deletions(-)
> > 
> > diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> > index fc3885d..c59e366 100644
> > --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> > +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> > @@ -478,14 +478,12 @@ static int wpa_set_encryption(struct net_device *dev, struct ieee_param *param,
> >  		if (wep_key_len > 0) {
> >  			wep_key_len = wep_key_len <= 5 ? 5 : 13;
> >  			wep_total_len = wep_key_len + FIELD_OFFSET(struct ndis_802_11_wep, KeyMaterial);
> > -			pwep = rtw_malloc(wep_total_len);
> > +			pwep = rtw_zmalloc(wep_total_len);
> 
> We should not introduce new uses of rtw_malloc() or rtw_zmalloc().  They
> are buggy garbage.  Use normall kmalloc() and kzalloc().
Hi Dan Carpenter,

Sure , will  resend this patch with suggested changes.

Thanks,
Hariprasad k

> 
> regards,
> dan carpenter