From: Christoph Hellwig <hch@infradead.org>
To: Puranjay Mohan <puranjay12@gmail.com>
Cc: Shuah Khan <skhan@linuxfoundation.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] fs: cramfs_fs.h: Fix shifting signed 32-bit value by 31 bits problem
Date: Mon, 17 Jun 2019 23:59:20 -0700 [thread overview]
Message-ID: <20190618065920.GA3620@infradead.org> (raw)
In-Reply-To: <20190618041257.5401-1-puranjay12@gmail.com>
> -#define CRAMFS_BLK_FLAG_UNCOMPRESSED (1 << 31)
> +#define CRAMFS_BLK_FLAG_UNCOMPRESSED (1U << 31)
> #define CRAMFS_BLK_FLAG_DIRECT_PTR (1 << 30)
Please use the unsigned constants for all flags, not just one.
prev parent reply other threads:[~2019-06-18 6:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 4:12 Puranjay Mohan
2019-06-18 6:59 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618065920.GA3620@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=puranjay12@gmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®