From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Enrico Weigelt, metux IT consult" <info@metux.net>
Cc: linux-kernel@vger.kernel.org, thloh@altera.com,
linus.walleij@linaro.org, bgolaszewski@baylibre.com,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
grygorii.strashko@ti.com, ssantosh@kernel.org,
khilman@kernel.org, mcoquelin.stm32@gmail.com,
alexandre.torgue@st.com, linux-gpio@vger.kernel.org,
linux-omap@vger.kernel.org, linux-tegra@vger.kernel.org,
patches@opensource.cirrus.com
Subject: Re: [PATCH 07/30] drivers: gpio: msic: use subsys_platform_driver()
Date: Tue, 18 Jun 2019 12:00:31 +0300 [thread overview]
Message-ID: <20190618090031.GK9224@smile.fi.intel.com> (raw)
In-Reply-To: <1560796871-18560-7-git-send-email-info@metux.net>
On Mon, Jun 17, 2019 at 08:40:48PM +0200, Enrico Weigelt, metux IT consult wrote:
> From: Enrico Weigelt <info@metux.net>
>
> Reduce driver init boilerplate by using the new
> subsys_platform_driver() macro.
> --- a/drivers/gpio/gpio-msic.c
> +++ b/drivers/gpio/gpio-msic.c
> @@ -306,9 +306,4 @@ static int platform_msic_gpio_probe(struct platform_device *pdev)
> },
> .probe = platform_msic_gpio_probe,
> };
> -
> -static int __init platform_msic_gpio_init(void)
> -{
> - return platform_driver_register(&platform_msic_gpio_driver);
> -}
> -subsys_initcall(platform_msic_gpio_init);
> +subsys_platform_driver(platform_msic_gpio_driver);
How did you test this? Had you even compiled it?
P.S. Perhaps it makes #include <linux/init.h> redundant.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-06-18 9:00 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 18:40 [PATCH 01/30] include: linux: platform_device: more helpers for declaring platform drivers Enrico Weigelt, metux IT consult
2019-06-17 18:40 ` [PATCH 02/30] drivers: gpio: altera: use subsys_platform_driver() Enrico Weigelt, metux IT consult
2019-06-17 18:40 ` [PATCH 03/30] drivers: gpio: da9055: " Enrico Weigelt, metux IT consult
2019-06-17 18:40 ` [PATCH 04/30] drivers: gpio: htc-egpio: " Enrico Weigelt, metux IT consult
2019-06-17 18:40 ` [PATCH 05/30] drivers: gpio: lynxpoint: " Enrico Weigelt, metux IT consult
2019-06-17 18:40 ` [PATCH 06/30] drivers: gpio: lantiq: " Enrico Weigelt, metux IT consult
2019-06-17 18:40 ` [PATCH 07/30] drivers: gpio: msic: " Enrico Weigelt, metux IT consult
2019-06-18 9:00 ` Andy Shevchenko [this message]
2019-06-17 18:40 ` [PATCH 08/30] drivers: gpio: palmas: " Enrico Weigelt, metux IT consult
2019-06-17 18:40 ` [PATCH 09/30] drivers: gpio: rc5t583: " Enrico Weigelt, metux IT consult
2019-06-17 18:40 ` [PATCH 10/30] drivers: gpio: spear-spics: " Enrico Weigelt, metux IT consult
2019-06-17 18:40 ` [PATCH 11/30] drivers: gpio: stmpe: " Enrico Weigelt, metux IT consult
2019-06-17 18:40 ` [PATCH 12/30] drivers: gpio: stp-xway: " Enrico Weigelt, metux IT consult
2019-06-17 18:40 ` [PATCH 13/30] drivers: gpio: tc3589x: " Enrico Weigelt, metux IT consult
2019-06-17 18:40 ` [PATCH 14/30] drivers: gpio: tegra: " Enrico Weigelt, metux IT consult
2019-06-17 18:40 ` [PATCH 15/30] drivers: gpio: tps6586x: " Enrico Weigelt, metux IT consult
2019-06-17 18:40 ` [PATCH 16/30] drivers: gpio: tps65910: " Enrico Weigelt, metux IT consult
2019-06-17 18:40 ` [PATCH 17/30] drivers: gpio: twl4030: " Enrico Weigelt, metux IT consult
2019-06-17 18:40 ` [PATCH 18/30] drivers: gpio: wm831x: " Enrico Weigelt, metux IT consult
2019-06-17 18:41 ` [PATCH 19/30] drivers: gpio: wm8350: " Enrico Weigelt, metux IT consult
2019-06-17 18:41 ` [PATCH 20/30] drivers: gpio: wm8994: " Enrico Weigelt, metux IT consult
2019-06-17 18:41 ` [PATCH 21/30] drivers: gpio: xilinx: " Enrico Weigelt, metux IT consult
2019-06-17 18:41 ` [PATCH 22/30] drivers: gpio: em: use postcore_platform_driver() Enrico Weigelt, metux IT consult
2019-06-17 18:41 ` [PATCH 23/30] drivers: gpio: ep93xx: " Enrico Weigelt, metux IT consult
2019-06-17 18:41 ` [PATCH 24/30] drivers: gpio: mxs: " Enrico Weigelt, metux IT consult
2019-06-17 18:41 ` [PATCH 25/30] drivers: gpio: omap: " Enrico Weigelt, metux IT consult
2019-06-17 18:41 ` [PATCH 26/30] drivers: gpio: zynq: " Enrico Weigelt, metux IT consult
2019-06-17 18:41 ` [PATCH 27/30] drivers: gpio: iop: use arch_platform_driver() Enrico Weigelt, metux IT consult
2019-06-17 18:41 ` [PATCH 28/30] drivers: gpio: mpc8xxx: " Enrico Weigelt, metux IT consult
2019-06-17 18:41 ` [PATCH 29/30] drivers: gpio: max7300: " Enrico Weigelt, metux IT consult
2019-06-17 18:41 ` [PATCH 30/30] drivers: gpio: max732x: use subsys_i2c_driver() Enrico Weigelt, metux IT consult
2019-06-18 8:57 ` [PATCH 01/30] include: linux: platform_device: more helpers for declaring platform drivers Andy Shevchenko
2019-06-25 9:18 ` Linus Walleij
2019-06-26 6:14 ` Uwe Kleine-König
2019-06-26 17:27 ` Enrico Weigelt, metux IT consult
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618090031.GK9224@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alexandre.torgue@st.com \
--cc=bgolaszewski@baylibre.com \
--cc=festevam@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=info@metux.net \
--cc=kernel@pengutronix.de \
--cc=khilman@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=patches@opensource.cirrus.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=ssantosh@kernel.org \
--cc=thloh@altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®