From: Anson.Huang@nxp.com
To: mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, catalin.marinas@arm.com, will.deacon@arm.com,
maxime.ripard@bootlin.com, olof@lixom.net,
horms+renesas@verge.net.au, jagan@amarulasolutions.com,
leonard.crestez@nxp.com, bjorn.andersson@linaro.org,
dinguyen@kernel.org, enric.balletbo@collabora.com,
aisheng.dong@nxp.com, ping.bai@nxp.com, abel.vesa@nxp.com,
l.stach@pengutronix.de, peng.fan@nxp.com,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: Linux-imx@nxp.com
Subject: [PATCH V5 3/5] clk: imx: Add API for clk unregister when driver probe fail
Date: Wed, 19 Jun 2019 13:52:45 +0800 [thread overview]
Message-ID: <20190619055247.35771-3-Anson.Huang@nxp.com> (raw)
In-Reply-To: <20190619055247.35771-1-Anson.Huang@nxp.com>
From: Anson Huang <Anson.Huang@nxp.com>
For i.MX clock drivers probe fail case, clks should be unregistered
in the return path, this patch adds a common API for i.MX clock
drivers to unregister clocks when fail.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
New patch.
---
drivers/clk/imx/clk.c | 8 ++++++++
drivers/clk/imx/clk.h | 1 +
2 files changed, 9 insertions(+)
diff --git a/drivers/clk/imx/clk.c b/drivers/clk/imx/clk.c
index f241189..8616967 100644
--- a/drivers/clk/imx/clk.c
+++ b/drivers/clk/imx/clk.c
@@ -13,6 +13,14 @@
DEFINE_SPINLOCK(imx_ccm_lock);
+void imx_unregister_clocks(struct clk *clks[], unsigned int count)
+{
+ unsigned int i;
+
+ for (i = 0; i < count; i++)
+ clk_unregister(clks[i]);
+}
+
void __init imx_mmdc_mask_handshake(void __iomem *ccm_base,
unsigned int chn)
{
diff --git a/drivers/clk/imx/clk.h b/drivers/clk/imx/clk.h
index 19d7b8b..bb4ec1b 100644
--- a/drivers/clk/imx/clk.h
+++ b/drivers/clk/imx/clk.h
@@ -12,6 +12,7 @@ void imx_check_clk_hws(struct clk_hw *clks[], unsigned int count);
void imx_register_uart_clocks(struct clk ** const clks[]);
void imx_register_uart_clocks_hws(struct clk_hw ** const hws[]);
void imx_mmdc_mask_handshake(void __iomem *ccm_base, unsigned int chn);
+void imx_unregister_clocks(struct clk *clks[], unsigned int count);
extern void imx_cscmr1_fixup(u32 *val);
--
2.7.4
next prev parent reply other threads:[~2019-06-19 5:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 5:52 [PATCH V5 1/5] dt-bindings: imx: Add clock binding doc for i.MX8MN Anson.Huang
2019-06-19 5:52 ` [PATCH V5 2/5] clk: imx8mm: Make 1416X/1443X PLL macro definitions common for usage Anson.Huang
2019-06-19 5:52 ` Anson.Huang [this message]
2019-06-19 5:52 ` [PATCH V5 4/5] clk: imx: Add support for i.MX8MN clock driver Anson.Huang
2019-06-19 5:52 ` [PATCH V5 5/5] arm64: defconfig: Select CONFIG_CLK_IMX8MN by default Anson.Huang
2019-07-09 17:05 ` [PATCH V5 1/5] dt-bindings: imx: Add clock binding doc for i.MX8MN Rob Herring
2019-07-22 1:50 ` Shawn Guo
2019-07-24 14:41 ` Rob Herring
2019-07-25 2:17 ` Anson Huang
-- strict thread matches above, loose matches on Subject: below --
2019-06-14 8:37 Anson.Huang
2019-06-14 8:37 ` [PATCH V5 3/5] clk: imx: Add API for clk unregister when driver probe fail Anson.Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190619055247.35771-3-Anson.Huang@nxp.com \
--to=anson.huang@nxp.com \
--cc=Linux-imx@nxp.com \
--cc=abel.vesa@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=enric.balletbo@collabora.com \
--cc=festevam@gmail.com \
--cc=horms+renesas@verge.net.au \
--cc=jagan@amarulasolutions.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=mturquette@baylibre.com \
--cc=olof@lixom.net \
--cc=peng.fan@nxp.com \
--cc=ping.bai@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome